[4.0]improved contrast in icon during installation

[bahl24]

Pull Request for Issue - Improved contrast and consistency for 'warning' label.

Testing

run node build.js --compile-css

Summary of Changes

Changed text color

Expected result

Actual result

[chmst]

@bahl24 good idea! But it is better not to use a color definition. Could you use the scss variable white instead?

[bahl24]

@chmst I have changed, but I was wondering why is white better than its hex code?

[chmst]

Indeed, at this place it makes no difference, as the background here also is white and probably will not be changed. So thank you - I will test this asap.

[bahl24]

@Quy Done

[Quy]

Actually lines 281-283 can be removed since the same class definition is defined starting at line 3420 in the generated template.css.

.badge-warning {
  color: #fff;
  background-color: #b35900; }
  a.badge-warning:hover, a.badge-warning:focus {
    color: #fff;
    background-color: #804000; }
  a.badge-warning:focus, a.badge-warning.focus {
    outline: 0;
    box-shadow: 0 0 0 0.2rem rgba(179, 89, 0, 0.5); }

[bahl24]

Actually lines 281-283 can be removed since the same class definition is defined starting at line 3420 in the generated template.css.

.badge-warning {
  color: #fff;
  background-color: #b35900; }
  a.badge-warning:hover, a.badge-warning:focus {
    color: #fff;
    background-color: #804000; }
  a.badge-warning:focus, a.badge-warning.focus {
    outline: 0;
    box-shadow: 0 0 0 0.2rem rgba(179, 89, 0, 0.5); }

Done

[chmst]

I have tested this item ✅ successfully on f2b231c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24213.}

[Quy]

I have tested this item ✅ successfully on f2b231c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24213.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24213.}