[4.0] [a11y] Remove title from fieldset#24275
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Mar 21, 2019
Merged
Conversation
The title attribute is generally not very accessible. Keyboard users and touch screen users will never see it. It is particularly useless to add a title which is the same as other text already present as that can result in a screen reader announcing the same text twice. This PR removes the redundant title attribute from two fieldsets as the same text is correctly present in the fieldset legend
Contributor
|
I have tested this item ✅ successfully on a84331a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24275. |
Contributor
|
Thanks! |
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title attribute is generally not very accessible. Keyboard users and touch screen users will never see it.
It is particularly useless to add a title which is the same as other text already present as that can result in a screen reader announcing the same text twice.
This PR removes the redundant title attribute from two fieldsets as the same text is correctly present in the fieldset legend