Skip to content

[4.0] [com_modules] Batch language broken#24273

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
infograf768:4.0_batchlanguagemodules
Mar 21, 2019
Merged

[4.0] [com_modules] Batch language broken#24273
wilsonge merged 1 commit intojoomla:4.0-devfrom
infograf768:4.0_batchlanguagemodules

Conversation

@infograf768
Copy link
Member

Pull Request for Issue #24264

Summary of Changes

Taking of the duplicate div displaying the Language field when using batch language for site modules.
Correcting cs (spaces instead of tabs)

Testing Instructions

Load Modules Manager. Select a module. Click on the Batch button.

Before patch

Screen Shot 2019-03-21 at 09 11 39

After patch

Screen Shot 2019-03-21 at 09 10 35

@infograf768
Copy link
Member Author

Beware

this should be tested on a clean install of the 4.0 branch as there were changes in db yesterday for com_modules.

@infograf768 infograf768 changed the title [4.0] [com_mdules] Batch language broken [4.0] [com_modules] Batch language broken Mar 21, 2019
@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 1010e35

Tested on a completely clean install


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24273.

@infograf768
Copy link
Member Author

It works perfectly here. No idea why it does not for you.

@brianteeman
Copy link
Contributor

Clean install with french installed and the multilingual setup plugin is failing exactly as I saw yesterday when I tried the same change

Site

image

Admin

image

@infograf768
Copy link
Member Author

infograf768 commented Mar 21, 2019

S0:
For site it is fine, your result is now OK.
For admin It does not depend on the multilingual setting at all. It works also for monolingual sites as it only depends on the installed admin languages and not content languages.

You do not get a Language field in your screenshot and this is correct if you have not set in com_modules Options the Language Filtering to YES
Screen Shot 2019-03-21 at 10 02 58

@brianteeman
Copy link
Contributor

I knew there was something I must have forgotten to do :)

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 1010e35

Tested on a completely clean install


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24273.

@wilsonge wilsonge merged commit 652cef3 into joomla:4.0-dev Mar 21, 2019
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 21, 2019
@infograf768 infograf768 deleted the 4.0_batchlanguagemodules branch March 21, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants