Skip to content

[4.0][com_users] Add cancel action to profile form#24088

Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom
SharkyKZ:j4/profileButton
Mar 21, 2019
Merged

[4.0][com_users] Add cancel action to profile form#24088
wilsonge merged 3 commits intojoomla:4.0-devfrom
SharkyKZ:j4/profileButton

Conversation

@SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Mar 4, 2019

This is an alternative to #24007 and #24087 PRs. Also in a sense solves #17875.

Summary of Changes

Adds cancel task to profile controller to allow the use of <button> element for accessibility reasons.

CC @zwiastunsw @tarot-ray @hardik-codes

Documentation Changes Required

New method added.

@brianteeman
Copy link
Contributor

Looks good

@zwiastunsw
Copy link
Contributor

I have tested this item ✅ successfully on fb65e36

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24088.

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Mar 6, 2019

Added formnovalidate to the cancel button so the form can be submitted when required fields are missing. @zwiastunsw can you re-test please?

@zwiastunsw
Copy link
Contributor

I have tested this item ✅ successfully on 35cf04e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24088.

1 similar comment
@softforge
Copy link
Contributor

I have tested this item ✅ successfully on 35cf04e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24088.

@Quy
Copy link
Contributor

Quy commented Mar 13, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24088.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 13, 2019
@wilsonge wilsonge merged commit 489f527 into joomla:4.0-dev Mar 21, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 21, 2019
@wilsonge
Copy link
Contributor

Much cleaner! Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants