[4.0][com_users] Add cancel action to profile form#24088
Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom Mar 21, 2019
SharkyKZ:j4/profileButton
Merged
[4.0][com_users] Add cancel action to profile form#24088wilsonge merged 3 commits intojoomla:4.0-devfrom SharkyKZ:j4/profileButton
wilsonge merged 3 commits intojoomla:4.0-devfrom
SharkyKZ:j4/profileButton
Conversation
Contributor
|
Looks good |
Contributor
|
I have tested this item ✅ successfully on fb65e36 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24088. |
Contributor
Author
|
Added |
Contributor
|
I have tested this item ✅ successfully on 35cf04e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24088. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 35cf04e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24088. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24088. |
Contributor
|
Much cleaner! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #24007 and #24087 PRs. Also in a sense solves #17875.
Summary of Changes
Adds cancel task to profile controller to allow the use of
<button>element for accessibility reasons.CC @zwiastunsw @tarot-ray @hardik-codes
Documentation Changes Required
New method added.