Skip to content

[4.0] com_templates sidebar#24092

Merged
wilsonge merged 4 commits intojoomla:4.0-devfrom
brianteeman:template_sidebar
Mar 21, 2019
Merged

[4.0] com_templates sidebar#24092
wilsonge merged 4 commits intojoomla:4.0-devfrom
brianteeman:template_sidebar

Conversation

@brianteeman
Copy link
Contributor

Removes the sidebar for templates and styles. They are not replaced as they are accessed directly from the system dashboard instead of the components menu

Removes the sidebar for templates and styles. They are not replaced as they are accessed directly from the system dashboard instead of the components menu
@infograf768
Copy link
Member

Just taking off the sidebar is not so nice.
If one edits a style or modifies a template file, then it is necessary to display again the System Cpanel to go to the other template manager.
New Toolbar buttons may help.

@brianteeman
Copy link
Contributor Author

Exactly as menitoned by @wilsonge in another PR and as I replied - that is beyond the scope of this pr and is perhaps something the template team have resolved already as the system dashboard is there idea

@Bodge-IT
Copy link
Contributor

Bodge-IT commented Mar 6, 2019

I have tested this item 🔴 unsuccessfully on 4f60f73

Cleared cache after patch applied.
Checked all System & Component links items and found sidebar in:

  • Clear Cache
  • Clear Expired Cache
  • Glocal
  • Warnings
  • Discover
  • Install Language
  • Extensions
  • Update Sources
  • Text Filters
  • Settings (Duplicates Global)
    Components:
  • Smart Search
  • Contacts
    • Categories

Templates sidebar was removed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24092.

@Quy
Copy link
Contributor

Quy commented Mar 6, 2019

@Bodge-IT This PR is for Templates sidebar.
24092

@brianteeman
Copy link
Contributor Author

@Bodge-IT As the pr says - this only removes the sidebar for templates and styles - not anything else. They all have their own prs

@Bodge-IT
Copy link
Contributor

Bodge-IT commented Mar 7, 2019

OK I missed that. I'll retest.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24092.

@softforge
Copy link
Contributor

I have tested this item ✅ successfully on 4f60f73

Tested and removes the sidebar in style and template in both site and administrator


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24092.

@Bodge-IT
Copy link
Contributor

Bodge-IT commented Mar 7, 2019

I have tested this item ✅ successfully on 4f60f73

Sidebar removed for Styles and Templates on both Site and Admin


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24092.

@ghost
Copy link

ghost commented Mar 7, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 7, 2019
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge merged commit a53a82d into joomla:4.0-dev Mar 21, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 21, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 21, 2019
@brianteeman
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants