Skip to content

[4.0][com_content] Remove column-related code.#23123

Merged
wilsonge merged 11 commits intojoomla:4.0-devfrom
SharkyKZ:removeColumns
Mar 21, 2019
Merged

[4.0][com_content] Remove column-related code.#23123
wilsonge merged 11 commits intojoomla:4.0-devfrom
SharkyKZ:removeColumns

Conversation

@SharkyKZ
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This removes remaining code related to column options in com_content. See #18319 and #22840 for details.

Testing Instructions

Code review.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Nov 20, 2018
@infograf768
Copy link
Member

NOTE

To @wilsonge @laoneo @Bakual @mbabker @rdeutz
Concerning installation/src/Model/LanguagesModel.php, what do we do with the methods which have allowed to install a basic multilingual site at installation time in 3.x as it looks like it has been apparently officially decided to drop this functionality in 4.0 in favor of the multilang sample data plugin.

I still question this decision btw. And it looks like I am not alone on this.

@Bakual
Copy link
Contributor

Bakual commented Nov 20, 2018

Can you ask this question in a separate issue? It's quite offtopic here as this PR is completely unrelated to that question.

@infograf768
Copy link
Member

I asked it here as the file has been modified and the methods may have to be totally deleted if the decision is confirmed. Just a Note to admins.

@Bakual
Copy link
Contributor

Bakual commented Nov 20, 2018

Still needs an own issue to be properly discussed so it doesn't derail this valid PR here.

@infograf768
Copy link
Member

sure

label="JGLOBAL_MULTI_COLUMN_ORDER_LABEL"
useglobal="true"
>
<option value="0">JGLOBAL_DOWN</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these two strings?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we should delete these strings as they may be used by 3pd.

@brianteeman
Copy link
Contributor

Personally I would not remove the language strings from the global language file. When I removed all unused strings earlier I left the ones in global files as those are the files recommended for extensions to utilise and I felt it was an unnecessary additional change they would have to make. My 2c

@Quy
Copy link
Contributor

Quy commented Nov 27, 2018

I have tested this item ✅ successfully on 62d7cb1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23123.

@joomla-cms-bot joomla-cms-bot added Unit/System Tests and removed Language Change This is for Translators labels Mar 1, 2019
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators and removed Unit/System Tests labels Mar 1, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Mar 1, 2019

@zero-24 @SniperSister RIPS please

@zero-24
Copy link
Contributor

zero-24 commented Mar 2, 2019

Fixed rips sorry that it took that long @wilsonge

@wilsonge
Copy link
Contributor

wilsonge commented Mar 2, 2019

@zero-24 doesn't seem to have worked? Or there's a new issue :( No worries about the time

@wilsonge wilsonge merged commit 69931c3 into joomla:4.0-dev Mar 21, 2019
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants