[4.0][com_content] Remove column-related code.#23123
[4.0][com_content] Remove column-related code.#23123wilsonge merged 11 commits intojoomla:4.0-devfrom SharkyKZ:removeColumns
Conversation
NOTETo @wilsonge @laoneo @Bakual @mbabker @rdeutz I still question this decision btw. And it looks like I am not alone on this. |
|
Can you ask this question in a separate issue? It's quite offtopic here as this PR is completely unrelated to that question. |
|
I asked it here as the file has been modified and the methods may have to be totally deleted if the decision is confirmed. Just a Note to admins. |
|
Still needs an own issue to be properly discussed so it doesn't derail this valid PR here. |
|
sure |
| label="JGLOBAL_MULTI_COLUMN_ORDER_LABEL" | ||
| useglobal="true" | ||
| > | ||
| <option value="0">JGLOBAL_DOWN</option> |
There was a problem hiding this comment.
Not sure we should delete these strings as they may be used by 3pd.
|
Personally I would not remove the language strings from the global language file. When I removed all unused strings earlier I left the ones in global files as those are the files recommended for extensions to utilise and I felt it was an unnecessary additional change they would have to make. My 2c |
|
I have tested this item ✅ successfully on 62d7cb1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23123. |
This reverts commit cc91af9.
|
@zero-24 @SniperSister RIPS please |
|
Fixed rips sorry that it took that long @wilsonge |
|
@zero-24 doesn't seem to have worked? Or there's a new issue :( No worries about the time |
|
Thanks! |
Pull Request for Issue # .
Summary of Changes
This removes remaining code related to column options in
com_content. See #18319 and #22840 for details.Testing Instructions
Code review.