Add a filter featured to content articles#23497
Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom Mar 21, 2019
Merged
Conversation
Quy
reviewed
Jan 10, 2019
| COM_CONTENT_FIELD_VERSION_LABEL="Revision" | ||
| COM_CONTENT_FIELD_XREFERENCE_DESC="An optional reference used to link to external data sources." | ||
| COM_CONTENT_FIELD_XREFERENCE_LABEL="External Reference" | ||
| COM_CONTENT_FILTER_FEATURED_NO ="Unfeatured Articles" |
Contributor
There was a problem hiding this comment.
Suggested change
| COM_CONTENT_FILTER_FEATURED_NO ="Unfeatured Articles" | |
| COM_CONTENT_FILTER_FEATURED_NO="Unfeatured Articles" |
Quy
reviewed
Jan 10, 2019
| COM_CONTENT_FIELD_XREFERENCE_DESC="An optional reference used to link to external data sources." | ||
| COM_CONTENT_FIELD_XREFERENCE_LABEL="External Reference" | ||
| COM_CONTENT_FILTER_FEATURED_NO ="Unfeatured Articles" | ||
| COM_CONTENT_FILTER_FEATURED_YES ="Featured Articles" |
Contributor
There was a problem hiding this comment.
Suggested change
| COM_CONTENT_FILTER_FEATURED_YES ="Featured Articles" | |
| COM_CONTENT_FILTER_FEATURED_YES="Featured Articles" |
|
I have tested this item ✅ successfully on 5f1f8b3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23497. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 5f1f8b3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23497. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23497. |
Member
|
@chmst could you please upgrade this branch |
Contributor
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
At the moment, it is not possible to filter for unfeatured articles in the content.
This PR adds a filter "featured" to the articles view
Testing Instructions
You should have at least one fieatured and at least one unfeatured article.
Apply the Patch and the list of filters in the Table Options has a new filter "featured".
Apply the filter to your articles.
Documentation Changes Required
yes .. new filter