Skip to content

[4.0][a11y]Extra column for icon featured#23757

Merged
wilsonge merged 7 commits intojoomla:4.0-devfrom
chmst:a11y-action-button-viewfeatured
Mar 21, 2019
Merged

[4.0][a11y]Extra column for icon featured#23757
wilsonge merged 7 commits intojoomla:4.0-devfrom
chmst:a11y-action-button-viewfeatured

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented Feb 3, 2019

Continues #23718 .

Summary of Changes

Column featured as separate column in com_content view featured

@ChristineWk
Copy link

I have tested this item ✅ successfully on 6bd100b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23757.

@ChristineWk
Copy link

ChristineWk commented Feb 3, 2019

<a href="" onclick="return false;" class="js-stools-column-order selected js-stools-button-sort" id="sorted" data-order="a.featured" data-direction="DESC" data-caption="Featured - descending" data-sort="descending"> <span> Featured</span> <span class="icon-arrow-up-3" aria-hidden="true"></span> <span class="sr-only"> Sort Table By: Featured</span> </a>
Was not possible to add Code (if correct) - so I tried now in this way :-)

@ChristineWk
Copy link

I have tested this item ✅ successfully on b811352


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23757.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Feb 8, 2019

I have tested this item ✅ successfully on b811352


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23757.

@Quy
Copy link
Contributor

Quy commented Feb 8, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23757.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 8, 2019
@brianteeman
Copy link
Contributor

@chmst what is the point in having ordering on the featured column. Evrything is featured so the order will never change

@wilsonge
Copy link
Contributor

@chmst As brian says can you remove the ordering. Just echo JFEATURED through jtext rather than using searchtools.sort

@chmst
Copy link
Contributor Author

chmst commented Mar 20, 2019

Sorry for delay ;)

@wilsonge wilsonge merged commit d8da246 into joomla:4.0-dev Mar 21, 2019
@wilsonge
Copy link
Contributor

Awesome stuff :) Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 21, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 21, 2019
@chmst chmst deleted the a11y-action-button-viewfeatured branch October 5, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants