[4.0] Fix modified time for new entries in fields and field groups#23978
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Mar 21, 2019
Merged
[4.0] Fix modified time for new entries in fields and field groups#23978wilsonge merged 2 commits intojoomla:4.0-devfrom
wilsonge merged 2 commits intojoomla:4.0-devfrom
Conversation
chmst
changed the title
HLeithner
reviewed
Feb 22, 2019
Contributor
|
I have tested this item ✅ successfully on cb06cb1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23978. |
2 similar comments
|
I have tested this item ✅ successfully on cb06cb1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23978. |
|
I have tested this item ✅ successfully on cb06cb1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23978. |
Contributor
|
I have tested this item ✅ successfully on cb06cb1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23978. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on cb06cb1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23978. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23978. |
Contributor
|
Thanks! Sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fields and Field Grops have modified Time = nwo and modified user_id = 0 in new entries.
This PR sets modified Time to Null Date for new entries and fixes an error in saving Field Groups.
Testing Instructions
Store a new Field.
Then store a new Field Group
Expected result
Field Field group ist stored, modified time is = nulldate, modified user ID = 0
Actual result
The Field has a modifiedd Time = now and modified_user_id = 0;
The Field group is not stored but ends with error.
Documentation Changes Required