Merged
Conversation
…ty (#9010) * Split out proofing components in analytics_spec for readabillity [skip changelog] * Split out proofing components in gpo flow of analytics spec * Split out proofing components for in person flow of analytics spec --------- Co-authored-by: Kimball Bighorse <kimball.bighorse@gsa.gov>
…8993) * LG-8886: Split percent logging for USPS proofing networking errors * LG-8886: Include connection error; update logged field name * changelog: Internal, In-Person Proofing, Log network error stats separately for USPS proofing results job
changelog: Internal, Code Quality, Remove deprecated (renamed) URL definitions
changelog: Internal, Static Analysis, Enable stricter rules for flash error handling
* changelog: User-Facing Improvements, Authentication Methods, Implement ability to select more than one MFA of the same type * add list of selected mfa options to Authentication Method setup followup view * fix lint errors * revise tests involving redirect to two-factor-options page * remove added scss, moved styles to utility classes * put confirmation step back into workflow * fix lint error * fix spec 3/22 * fix build errors * fix build errors * fix build errors * fix bug: adding new mfa from account page ended up on add second mfa page * fix lint * reset test * reset test * reset test * reset test * fix spec test to account for redirecting to add second mfa screen * review comment changes * review comment changes * review comment changes * move mfa_added logic to presenter and out of view files * pr review comments * revert account setup to original workflow * address review comments. fix html bug, refactor presenter logic * fix build error * add nil-safe operator * fix build error * fix build error * fix lint * fix build * fix lint * fix build * move null operator to method * fix build error * refactor backup code presenter * adds test cases * correct double equals operator * fix indentation * make test for disabled more robust * fix disabled test case * correct spec test logic * removes stubbed in nil state * face or touch unlock mfa only 1x available at signup * fix build error * fix build error * fix build * fix build * De-indent * Apply default disabled logic only to setup * Always pass user to selection presenter Avoid having to deal with nil user * Make user required argument * fix build error * fix build * fix lint * fix build errors * refactor for correct :user and :configuration variable * fix lint * streamline spec use of user keyword, add selection_presenter test --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Add bin/oncall/otp-deliveries **Why**: Script to help triage OTP deliveries by pulling message IDs changelog: Internal, Scripts, Add script to triage OTP delivery
…sts (#9020) * refactor child jobs & rewrite their tests changelog: Internal, In-person proofing, Refactor USPS proofing job subclasses and their tests
) * merge conflict resolved * changelog: Bug Fixes, Identity Verification, A user who has completed verify info step is redirected to next step if navigating to redo-document capture * bypass redo document capture redo if verify info completed * rediret to review url if verify info is complete * check verify info step has been completed before allowing document caputre * check verify info completed as first before_action
* Fix output for running console in review application changelog: Internal, Continuous Integration, Fix output for running console in review application * disable token refresh jobs in review apps * use mock tmx
* Add controller spec for Idv::AddressController Really basic as there wasn't one before [skip changelog] * Set idv_session.address_edited * Read address_edited from idv_session or flow_session * Assert that address update logs an analytics event
…DV review step (#9024) * do not enforce idv rate limiter on review controller changelog: Bug Fixes, Identity Verification, Allow a user rate-limited user to re-enter password on review/Secure your account step" * refactor test * refactor test * verify analytics for letter enqueued for rate limited user
…on on Sign In page (#9018) * Add logging for IdV accordion on home page changelog: Internal, analytics, add analytics tracking for IdV requirements accordion * alphabetize events list * add analytics event * add logging for required pii accordion * rip out accordion react element * sort analytics event * changelog: Internal, analytics, add analytics for you will need accordion * Update app/services/analytics_events.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
changelog: Internal, Scripts, Add bin/oncall/download-piv-certs
changelog: Internal, Dependencies, Update dependencies to resolve security advisories
* Add second template for Welcome controller for A/B test We got unexpected results for our A/B test for the GettingStarted page that replaces both the Welcome and Agreement steps. Add a third option that just replaces the Welcome template with one that has the new content for the GettingStarted page (except the Agreement content) and then sends the user to the Agreement step as usual. changelog: User-facing Improvements, Identity Verification Getting Started Experience, Additional Welcome template for three-way A/B test Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> * Erb spec for Welcome template A/B test Co-authored-by John Maxwell <john.maxwell@gsa.gov> * Add controller spec for rendering the right partial * Update analytics_spec A/B test bucket :welcome -> :welcome_default Co-authored-by Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
…9017) changelog: Internal, Doc Auth, Delete CaptureTroubleshooting Component and update tests We don't want to show troubleshooting tips this way any longer. Instead, we're looking to use the help center for showing this sort of advice. In #8842, in order to avoid showing the tips, we increased the amount of tries before showing the tips to well past the maximum amount of total tries. Upon further discussion, we decided it would be better to remove the CaptureTroubleshooting component entirely, as we have no plans to reuse it in the future. Once CaptureTroubleshooting was removed, a few more things were now unused and could also be removed - the config setting the amount of tries before tips were shown, the copy used in the tips, the CaptureAdvice component, and any place calling these things. Includes removing imports that are now unused within the spec file and unused svg files Implementation notes: - we chose to [use fragment instead of div](https://medium.com/fasal-engineering/what-are-react-fragments-or-the-react-empty-tags-190253582905) when replacing the `CaptureTroubleshooting` wrapper in order to avoid unnecessary HTML elements.
* LG-10670: use different locations for troubleshooting links. changelog: Internal, Analytics, Using different locations for troubleshooting links.
changelog: Bug fixes, Partner Dashboard improvements, Allowing single service providers to sync in lower environments
Send the user a reminder email if they have a GPO letter outstanding, it's been two weeks, and they haven't entered the confirmation code from the letter. --------- changelog: User-Facing Improvement, Identity Verification, Added GPO 2 week reminder email Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Backfill the new `in_person_verification_pending_at` column. Co-authored by: Alexander Bradley <alexander.bradley@gsa.gov> Changelog: Internal,In-person proofing,Backfill new in_person_verification_pending_at column
* Add in person proofing cancel barcode scenario in end to end idv spec Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com> * Revert "Add in person proofing cancel barcode scenario in end to end idv spec" This reverts commit 34c7434. * Modify cancel spec to capture barcode cancel bug * Set in_person_verification_pending_at on profile when user cancels their barcode in person verification --------- Co-authored-by: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
#9030) * LG-8886: Catch and log network error when renewing USPS API auth token changelog: Internal, In-Person Proofing, Catch and log network error when renewing USPS API auth token * LG-8886: Correct yard doc for analytics method
We are moving data from flow_session to idv_session. Now that both the unsupervised and in person Ssn steps are out of the Flow State Machine, we can move threatmetrix_session_id to idv_session. This PR adds it to idv_session, and a followup PR for the next deploy will remove it from flow_session. [skip changelog]
* Add BIMI ("Tiny Portable Secure") SVG logo
changelog: Upcoming Features, Email Brand Identifier, Add logo to be used as email brand identifier
* Add specs for BIMI image validity
* Exclude login-icon-bimi from SVGO
* Use HTTP response for all assertions
See: #9040 (comment)
* Add viewBox attribute to BIMI image
* Move contents of OutageConcern into IdvStepConcern Since it was only two methods and that was the only place it was included. [skip changelog] * Rename #check_for_outage to #check_for_mail_only_outage * Change flow_session[:skip_vendor_outage] to idv_session.mail_only_warning_shown * Rename GpoOnlyWarningController to MailOnlyWarningController * Rename FeatureManagement.idv_gpo_only? to FeatureManagement.idv_by_mail_only? * Check if idv_session is defined before using it.
zachmargolis
approved these changes
Aug 21, 2023
The GPO reminder job currently has a query that sends an email to users who are GPO pending. Unfortunately it is configured to send an email to every user who has ever been GPO pending. As a result every pending user from all of history will receive an email once it is merged. This commit temporarily disables the job while we figure that problem out. [skip changelog]
jmhooper
approved these changes
Aug 22, 2023
Contributor
jmhooper
left a comment
jmhooper
left a comment
There was a problem hiding this comment.
Looks like that commit got cherry-picked!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features