Remove deprecated routes

[aduth]

🛠 Summary of changes

Removes route configurations associated with previous renames that had kept a redirect in place for initial deploy, but hadn't followed-up with removal of the redirect.

Follow-up to:

• LG-6043: first change over to new url #6353
• Rename setup_errors to please_call #8094
• LG-9838: Move GPO routes under /verify #8586
• LG-9939 Addendum: Make /verify/doc_auth/:step redirect to /verify/welcome #8729

I checked traffic in production.log for the affected paths and there's essentially no traffic for them in the past week. What little traffic exists appears to be largely vulnerability probing (URLs containing strange query parameters, "xss" and the like).

📜 Testing Plan

Expect that valid URLs are still reachable.

[soniaconnolly]

LGTM. Thanks for doing this cleanup. I wasn't sure how long to keep the deprecated routes in place, and checking the logs is a good way to do it.

[theabrad]

LGTM

[aduth]

I wasn't sure how long to keep the deprecated routes in place, and checking the logs is a good way to do it.

Yeah, my assumption would generally be that authenticated routes would only need to have some backwards-compatibility for the deploy during which the rename is happening, since we don't "remember" the URL during sign-in to need to be able to support linking from third-parties (LG-3737).

There are a handful of other redirects that are pretty old that I might have thought were meant to be some "entrypoint" that we wanted to continue supporting, but even these I'm not sure are necessary / receive any traffic. Some like https://secure.login.gov/profile/reactivate are just straight-up broken already.

identity-idp/config/routes.rb

Lines 281 to 283 in 108d538

	get '/profile', to: redirect('/account')
	get '/profile/reactivate', to: redirect('/account/reactivate')
	get '/profile/verify', to: redirect('/account/verify')

[aduth]

There are a handful of other redirects that are pretty old that I might have thought were meant to be some "entrypoint" that we wanted to continue supporting, but even these I'm not sure are necessary / receive any traffic. Some like https://secure.login.gov/profile/reactivate are just straight-up broken already.

cc @zachmargolis in case you have opinions / can even remember from #1407 😄

[aduth]

I'm going to put this back in draft because removing the routes has revealed that some views still use the legacy path helpers, so we'll want to update those in a separate deploy.

[aduth]

I'm going to put this back in draft because removing the routes has revealed that some views still use the legacy path helpers, so we'll want to update those in a separate deploy.

Separate changes in #8990

[aduth]

I'll need to rebase this, but it should be unblocked now as #8990 is live in production as of today's release.

[zachmargolis]

cc @zachmargolis in case you have opinions / can even remember from #1407 😄

I do not remember! Looks like I was worried about preserving old links, but since you checked the logs and these aren't used, sounds like we can remove!