LG-10553 remove skip vendor outage from flow session#9042
Merged
soniaconnolly merged 6 commits intomainfrom Aug 21, 2023
Merged
LG-10553 remove skip vendor outage from flow session#9042soniaconnolly merged 6 commits intomainfrom
soniaconnolly merged 6 commits intomainfrom
Conversation
Since it was only two methods and that was the only place it was included. [skip changelog]
soniaconnolly
force-pushed
the
sonia-lg-10553-remove-skip-vendor-outage-from-flow-session
branch
from
8dfb002 to
736837d
Compare
theabrad
reviewed
Aug 21, 2023
|
|
||
| def next_step_url | ||
| return idv_gpo_url if FeatureManagement.idv_gpo_only? | ||
| return idv_gpo_url if FeatureManagement.idv_by_mail_only? |
Contributor
There was a problem hiding this comment.
mail_only is a much better name!
theabrad
approved these changes
Aug 21, 2023
Contributor
theabrad
left a comment
theabrad
left a comment
There was a problem hiding this comment.
LGTM. mail_only_outage is more descriptive for what it does.
matthinz
approved these changes
Aug 21, 2023
Contributor
matthinz
left a comment
matthinz
left a comment
There was a problem hiding this comment.
LGTM, I like the renames and the removing of OutageConcern
soniaconnolly
deleted the
sonia-lg-10553-remove-skip-vendor-outage-from-flow-session
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10553
🛠 Summary of changes
Note: Do not deploy this during a phone outage to avoid 50/50 state issues with moving the flow_session value to idv_session.
📜 Testing Plan
vendor_status_sms: full_outagein application.yml