LG-10062 Allow updater to update a single service provider #9032
Merged
LG-10062 Allow updater to update a single service provider #9032
Conversation
3 tasks
Jeremy1026
approved these changes
Aug 17, 2023
Comment on lines
31
to
33
Contributor
There was a problem hiding this comment.
are we doing a form post?
if we switched to JSON encoding of the body when we post, we'd likely preserve boolean true
Contributor
There was a problem hiding this comment.
Rails will automatically parse JSON when entire POST bodies are JSON (if the Content-Type header is set correctly) so I don't think we need to do that
Contributor
Author
There was a problem hiding this comment.
hm ok i hadn't updated the headers of the original request, i'll do that and see if it works!
Contributor
Author
There was a problem hiding this comment.
fixed here 2be634b (#9032) and on the dashboard here: 18F/identity-dashboard@c4aa305 (#663)
9960f3f to
3143ce1
Compare
zachmargolis
approved these changes
Aug 18, 2023
mitchellhenke
approved these changes
Aug 18, 2023
… service providers to sync in lower environments
3143ce1 to
2cad32d
Compare
mitchellhenke
approved these changes
Aug 21, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-10062
🛠 Summary of changes
When a partner on the dashboard side updates their sandbox configurations, those are synced with the int environment. The updater historically has pinged the dashboard to get a full list of service provider and then synced through the entire list. This no longer scales for the number of sandbox configurations we have and has led to many timeouts.
This change updates the updater to accept a service_provider param, and uses that param to update a single service_provider. It does not remove/alter the existing code, which may be in use in other parts of the application.
It has this associated PR on the Dashboard application.
Open questions:
nativeattribute? It appears that that is a deprecated attribute, but I didn't want to remove it without more context.nativeattribute. will follow up in a separate PR to remove itallview. we should move this code out of the API section as part of our tech debt work as the update requires a session.