Conversation
zachmargolis
approved these changes
Aug 18, 2023
spec/requests/bimi_logo_spec.rb
Outdated
Contributor
There was a problem hiding this comment.
should we assert any of the things about the file that it matches the BIMI spec? is less than 32kb, doesn't have attributes on the root element, etc?
Contributor
There was a problem hiding this comment.
I think it's a good idea, yeah. We have some similar patterns in spec/svg_spec.rb
changelog: Upcoming Features, Email Brand Identifier, Add logo to be used as email brand identifier
zachmargolis
approved these changes
Aug 21, 2023
mitchellhenke
approved these changes
Aug 21, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Adds a logo within
public/so that it can be referenced in BIMI DNS records.References:
TBD:
📜 Testing Plan