LG-8886: Split percent logging for USPS proofing networking errors#8993
Merged
LG-8886: Split percent logging for USPS proofing networking errors#8993
Conversation
8 tasks
…rately for USPS proofing results job
…86/handle-usps-network-errors
Contributor
|
Pretty straight-forward. LGTM. |
5 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
🛠 Summary of changes
📜 Testing Plan
in_person_enrollments_ready_job_enabledis disabledGetUspsWaitingProofingResultsJobas forGetUspsProofingResultsJobif the flag is enabled.GetUspsReadyProofingResultsJobwill only work for this test if the record already has the ready flag set.usps_mock_fallbackenabledUspsInPersonProofing::Mock::Proofer.request_proofing_resultsto throwFaraday::TimeoutErrorlog/events.logincludes theGetUspsProofingResultsJob: Job completedwith the following fields:enrollments_network_error=1percent_enrollments_network_error=100.00enrollments_errored=0percent_enrollments_errored=0.00UspsInPersonProofing::Mock::Proofer.request_proofing_resultsto throwFaraday::ServerErrorlog/events.logincludes theGetUspsProofingResultsJob: Job completedwith the following fields:enrollments_network_error=0percent_enrollments_network_error=0.00enrollments_errored=1percent_enrollments_errored=100.00