Jmax/lg 9565 two week gpo letter reminder email#9001
Conversation
ad28efa to
bc9636b
Compare
b4b8379 to
a44baba
Compare
config/locales/idv/es.yml
Outdated
There was a problem hiding this comment.
The Spanish translation is using informal you, and the French translation below is using formal you. I'll add this to the Translations Quality Tracker doc.
Out of curiosity, where is the attached yaml file? I just click "verify by mail instead" on the Phone step. Usually yaml files are to trigger in person proofing. |
soniaconnolly
left a comment
There was a problem hiding this comment.
Tested this out, works as described. There weren't instructions for how to run the GpoReminderJob, so I ran GpoReminderJob.new.perform(14.days.ago).
Not approving because I ran the job again and got a second email. I thought we were limiting it to one reminder per user.
Should the 14 days be a config setting? Or maybe that's a future PR - make the job send emails for whatever intervals appear in a config setting.
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM, with a couple of comments.
There was a problem hiding this comment.
Wondering if we need an index here. Are we querying the usps_confirmation_codes table by when reminders were sent?
There was a problem hiding this comment.
Yes, we are querying that, although it's not immediately obvious. The index is for the benefit of the code in GpoReminderSender, where we do a join that this index helps.
changelog: User-Facing Improvement, Identity Verification, Added GPO reminder email
Fixed incorrect help link.
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Cleaned up I18n HTML handling per Zach.
Stopped passing analytics in, because it's unfashionable.
Changed `@date_letter_was_sent` to `@gpo_verification_pending_at` in gpo letter reminder email template. More clearly states the value being dealt with.
7ea4caa to
e563453
Compare
🎫 Ticket
LG-9565
🛠 Summary of changes
Added a new reminder email for users who requested a GPO letter two weeks ago.
Added task to send such letters daily.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
gpo_verification_pending_atcolumn for one user's pending profile. Run the GpoReminderJob from the rails console (GpoReminderJob.new(14.days.ago), and verify that the expected email was sent to the user that you backdated, and that no email is sent to the other user.👀 Screenshots
English:
Spanish:
French: