Enable ActionControllerFlashBeforeRender Rubocop#8986
Merged
Conversation
mitchellhenke
approved these changes
Aug 11, 2023
soniaconnolly
approved these changes
Aug 11, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
Look good to delete flash[:allow_confirmations_continue]. It looks like it might have been used to allow refreshing the Personal Key page, but Jessica and I tried it with remote proofing, verify by mail, and combo in person and verify by mail, and it was still possible to refresh the Personal Key page in all cases. Like on main, refreshing it generates a new key.
aduth
force-pushed
the
aduth-rubocop-flash-before-render
branch
from
386ecf3 to
73c1b6b
Compare
changelog: Internal, Static Analysis, Enable stricter rules for flash error handling
aduth
force-pushed
the
aduth-rubocop-flash-before-render
branch
from
73c1b6b to
19e43e7
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Enables
Rails/ActionControllerFlashBeforeRenderand resolves existing issues.Why?
Previously:
📜 Testing Plan