LG-10518: Delete capture troubleshooting component and update tests#9017
Conversation
kellular
left a comment
There was a problem hiding this comment.
LGTM - I'm ok with deleting this copy if we are certain this is not being used anywhere right now
|
@night-jellyfish I'm not sure if you saw this in the build yet, but if you run the task |
|
Thank you, @eileen-nava ! I had just figured out how to log back into Gitlab and saw that error, but I didn't realize we had a check like that. That's pretty cool! I wonder if it should be in Anyways, I pushed up a commit deleting those unused translations. |
app/javascript/packages/document-capture/components/capture-advice.jsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/documents-step.jsx
Outdated
Show resolved
Hide resolved
eileen-nava
left a comment
There was a problem hiding this comment.
I left a few comments. Also, I agree with @aduth that if the photos from the deleted component aren't being used anywhere else, it would be good to delete them.
app/javascript/packages/document-capture/components/documents-step.jsx
Outdated
Show resolved
Hide resolved
or run bundle exec i18n-tasks health |
45f527f to
2754d1f
Compare
eileen-nava
left a comment
There was a problem hiding this comment.
Approved! Thanks for being so diligent about responding to feedback.
Originally we were going to test that the tips copy wasn't shown. But now that we're deleting the copy from the repo entirely, expecting the tips not to be shown, in a way, would be keeping the tips in the repo. So instead, we are are adding a test to make sure we see what we expect on the mobile side. Implementation note: We have to freeze time; otherwise the `timeout` will cause the test to flicker. (Example: The test will look for "try again in 6 hours" but the page will say "try again in 5 hours and 59 minutes".)
Includes removing imports that are now unused within the spec file
…t and update tests
Initially I found I needed this when I had the test running in the desktop context. But when I ran the test in the mobile context, I didn't seem to need it. I just saw the test flicker again with a console log error, so I am adding it back in to guard against future flickering.
b274e88 to
3bf8136
Compare
🎫 Ticket
LG-10518
🛠 Summary of changes
We don't want to show troubleshooting tips this way any longer. Instead, we're looking to use the help center for showing this sort of advice.
In #8842, in order to avoid showing the tips, we increased the amount of tries before showing the tips to well past the maximum amount of total tries. Upon further discussion, we decided it would be better to remove the
CaptureTroubleshootingcomponent entirely, as we have no plans to reuse it in the future.Once
CaptureTroubleshootingwas removed, a few more things were now unused and could also be removed - the config setting the amount of tries before tips were shown, the copy used in the tips, theCaptureAdvicecomponent, and any place calling these things.We also wanted to add a test to make sure we see what we are expecting to see when max attempts are reached.
📜 Testing Plan
(Stolen shamelessly from @eileen-nava's PR linked above, as that PR and this one are testing the same outcome)
glareThresholdinonAcuantImageCaptureSuccessmethod to 100)👀 Screenshots
(Also stolen shamelessly from @eileen-nava's PR linked above, for the same reason)
Here is a screenshot of the page that we DON'T want the user to see
Document Capture Tips: