Conversation
changelog: Internal, analytics, add analytics tracking for IdV requirements accordion
jmdembe
commented
Aug 16, 2023
| # In rare circumstances, these writes can clobber other, more important writes. | ||
| before_action :skip_session_commit | ||
|
|
||
| # Please try to keep this list alphabetical as well! |
Contributor
Author
There was a problem hiding this comment.
This might be an opportunity to script this?
Contributor
There was a problem hiding this comment.
We could consider adding a controller spec to check that it's sorted?
e.g.
expect(described_class::EVENT_MAP.keys).to eq(described_class::EVENT_MAP.keys.sort)
aduth
reviewed
Aug 16, 2023
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
mdiarra3
approved these changes
Aug 17, 2023
aduth
approved these changes
Aug 17, 2023
| # In rare circumstances, these writes can clobber other, more important writes. | ||
| before_action :skip_session_commit | ||
|
|
||
| # Please try to keep this list alphabetical as well! |
Contributor
There was a problem hiding this comment.
We could consider adding a controller spec to check that it's sorted?
e.g.
expect(described_class::EVENT_MAP.keys).to eq(described_class::EVENT_MAP.keys.sort)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10418: Add analytics tracking for "You will also need" IdV accordion on Sign In page
🛠 Summary of changes
This PR adds analytics tracking for the "You will also need" accordion on the sign in page, specifically if the user requires identity verification