Refactor GetUspsProofingResultsJob child classes and rewrite their tests#9020
Merged
tomas-nava merged 5 commits intomainfrom Aug 17, 2023
Merged
Conversation
changelog: Internal, In-person proofing, Refactor USPS proofing job subclasses and their tests
tomas-nava
requested review from
a team and
allthesignals
and removed request for
a team and
night-jellyfish
Contributor
|
zachmargolis
approved these changes
Aug 17, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Related to LG-8441 and LG-8034
🛠 Summary of changes
Refactored the
GetUspsReadyProofingResultsJobandGetUspsWaitingProofingResultsJobclasses to reduce duplication and rewrote their tests to more thoroughly test how they differ from their parent class (GetUspsProofingResultsJob). I also deleted tests that were already covered by their parent class's tests.