Conversation
changelog: Bug Fixes, Identity Verification, Allow a user rate-limited user to re-enter password on review/Secure your account step"
amirbey
changed the title
amirbey
changed the title
soniaconnolly
approved these changes
Aug 17, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM! I didn't know about skip_before_action. I like that the new test confirms the analytics.
I tested in main and confirmed the bug, then switched to this branch and confirmed I was able to continue and reenter my password.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10652
🛠 Summary of changes
Remove rate limit check in review controller. A user can be rate limited for phone entries and select GPO verification.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.