Split out proofing components in analytics feature spec for readability#9010
Merged
soniaconnolly merged 6 commits intomainfrom Aug 16, 2023
Merged
Split out proofing components in analytics feature spec for readability#9010soniaconnolly merged 6 commits intomainfrom
soniaconnolly merged 6 commits intomainfrom
Conversation
[skip changelog] Co-authored-by: Kimball Bighorse <kimball.bighorse@gsa.gov>
soniaconnolly
requested review from
a team,
jmhooper,
mitchellhenke and
zachmargolis
soniaconnolly
changed the title
soniaconnolly
requested review from
a team and
dawei-nava
and removed request for
a team
zachmargolis
approved these changes
Aug 15, 2023
Contributor
|
I like the new format. The file is easier to read. I can't see a reason not to apply this change to the other paths in this file. |
gina-yamada
approved these changes
Aug 16, 2023
dawei-nava
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Proposed format change for analytics feature spec to make it more readable and easier to make analytics changes. Proofing components have been put on their own line. This is only a white space and line re-ordering change to put the proofing component on a second line and all other attributes on the event's first line.
Note that only the happy path has been changed but commits will be added for the other paths if we agree we want to do this.