Merged
Conversation
* Convert document-capture.jsx to TypeScript * Display step indicator in React app for document capture **Why**: In support of LG-6308, we'll want the ability to dynamically change the rendered contents of the step indicator while still at the document capture step. changelog: Upcoming Features, In-person proofing, Show correct step indicator at each step * Update specs to account for removed local assigns
* Rename JavaScript addPageAction to trackEvent **Why**: - For alignment to the Ahoy/CloudWatch-based Ruby track_event method, to which it corresponds - For alignment to 18f/identity-analytics trackEvent method, which it wraps - To avoid falsely aligning to NewRelic's addPageAction, to which it does **not** correspond changelog: Internal, Analytics, Align JavaScript and Ruby analytics logging method name * Add README.md for analytics package
**Why**: The specs should pass regardless of the configured value, as in-person proofing does not depend on FSMv2. Additionally, we should expect that the default value is the more commonly-desired value (and likely matches the production experience). [skip changelog]
**Why**: because other errors were slipping through and not being rescued correctly changelog: Bug fixes, Multi-factor authentication, handle errors from vendors better
* LG-7095 Add Document upload method select event changelog: Internal, Attempts API, Track additional events
…ent (#6799) Add tracking for forgot password email sent event & throttle event changelog: Internal, Account Recovery, Add tracking for forgot password email sent event (LG-7084)
* LG-7097 Update Event: IDV phone upload link sent changelog: Internal, Attempts API, Update in tracking event * Update app/services/idv/steps/send_link_step.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* LG-6308: Show in-person step indicator in initial steps **Why**: It's expected that the step indicator should update to reflect in-person steps as soon as the user opts to verify in-person, which technically occurs while the user is still at the document capture step. changelog: Upcoming Features, In-person proofing, Show correct step indicator at each step * Use step indicator assertion helper consistently * Revert to specific typing * Remove duplicate string reference * Include helper module to define expect_step_indicator_current_step
changelog: Internal, Attempts API, Track additional events
* LG-6970 create inherited proofing basic landing page * fix lint errors for 2 files (get_started.html.erb, en.yml) * add inherited_proofing_enabled feature flag changelog: Improvements, inherited proofing, Create basic landing page * Fix formatting * Add missing translations to pass specs * Make placeholders consistent :S * Fix inconsistent interpolation across fr and es locales * optimize template button as a submit (w/o js-consent-continue-form) Co-authored-by: gangelo <web.gma@gmail.com>
…6827) * initial setup of redirect on device profiling failed * Redirect upon threatmetrix profiling failing changelog: Upcoming Features, Device Profiling, Redirect to come back later URL upon threatmetrix profiling failing. * added tests for nil check and passing check * Added device profiling pass check to password confirm controller * pass users who's device profiling returns nil
**Why**: As a precursor to #6841, in order to prevent timing issues between upgrading to Node.js v16 in the IdP and in the GitLab CI runner, update specs so that they pass in the current (14) and upgraded (16) versions. changelog: Internal, Build Tooling, Upgrade Node.js to v16
**Why**: provide more info to debug network errors vs logic errors, etc changelog: Internal, Logging, Update logging from network requests to vendors
changelog: Internal, Background Jobs, Update good_job library
[skip changelog]
changelog: Internal, Attempts API, Track additional events
changelog: Internal, Attempts API, Update in tracking event
changelog: Internal, Attempts API, Store key ID in return
And a few other fixes: - updating the mock proofer to be more realistic - update plumbing - remove uuid_prefix as a job argument since it's already inside applicant_pii changelog: Internal, Bug fixes, Updates data sent to vendors
* Use non-hashed SSN param, removed hashed version * changelog: Internal, ThreatMetrix API, Use non-hashed param * Removed keys (and added one) from stored API response to be more real
* Clean up some spec stragglers that now have different required params [skip changelog]
This code is unused and doesn't run anywhere. It was added as part of an experiment which has wrapped up and will not be turned on. changelog: Internal, Code Cleanup, Unused DOB year only code was cleaned up Co-authored-by: Kimball Bighorse <kbighorse@yahoo.com>
* changelog: Internal, Account recovery, Personal Key Reactivation * perosnal key fix * spec
**Why**: Since they are duplicated and one is unused. Consolidate on the name without "pending" reference to avoid ambiguity between "establishing" and "pending" enrollment statuses (technically, the enrollment is still "establishing" at this point, not "pending"). Removes feature guard conditions to avoid future clean-up, since it would be safe to check the proofing component with the understanding that it would only be assigned in earlier steps if the feature were enabled. [skip changelog]
* LG-6988 Email Submission Rate Limit events changelog: Internal, Attempts API, Track additional events
**Why**: It seems to be unused [skip changelog]
* Add account_drivers_license_number, removed hashed version * Add account_drivers_license_issuer to request and state_id_issued to tests * LG-7384 changelog: changelog: Internal, ThreatMetrix API, Use non-hashed param * Should have been called state_id_jurisdiction * changelog: Internal, ThreatMetrix API, Use non-hashed param
Add tracking method idv_phone_otp_submitted changelog: Internal, Attempts API, Track event idv_phone_otp_submitted (LG-7103)
* Clarify email delivery in local development From some anecdotal feedback I've heard from developers: - Some have expected that the application would send real emails - Clarify that the application does not send real emails - Some would test email template changes by going through the real flows - Clarify that Rails template previews exist to simplify this process changelog: Internal, Documentation, Improve onboarding documentation for application emails * Format email preview options as list See: #6863 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> Co-authored-by: Zach Margolis <zbmargolis@gmail.com>
* changelog: Internal, Identity Verification IRS Attempts API, Add additional Logging for SSN entering for IRS * tracker events * LG-7099: update to use existing format for ssn submit * update spec
* changelog: Internal, IRS attempts API, Add tracking for sending Address Validation * gpo spec
…out. (#6862) * moved rate_limited events to be called before sign out. changelog: Internal, Attempts API, Bugfix events * removed success parameter from spec * updated type parameter name for consistency * updated type parameter name for enroll event in test * linter fixes
…6874) changelog: Improvements, Attempts API, Increase strictness in parsing timestamp parameter
* Add Rubocop Style/BlockDelimeter cop
**Why**: consistency around do..end vs {} blocks
[skip changelog]
changelog: Internal, Inherited Proofing Tests, LG-7394 Establish Sandbox Connection to the VA
* update GpoConformationExporter to not include https in the domain name * remove https://
* Add new TMX failure proofing page * TMX failure page matches design * added translations * changed device_profiling_failed? to blocked_by_device_profiling? * fix linting errors changelog: Upcoming Features, ThreatMetrix, Add a page for when device profiling fails * add test * move mock contact url into config * move contact link text into a config variable * fixup * moved support_code to config value
stevegsa
approved these changes
Aug 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Bug Fixes
Internal
Upcoming Features