LG-7097 Update Event: IDV phone upload link sent#6838
Merged
olatifflexion merged 2 commits intomainfrom Aug 25, 2022
Merged
Conversation
changelog: Internal, Attempts API, Update in tracking event
n1zyy
approved these changes
Aug 24, 2022
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
I like how this came out.
To capture the intent for posterity -- this lets us give an indication of what went wrong, without returning the verbatim "We are experiencing technical difficulties. Please try again later." error string. Other possible errors in telephony/errors.rb tend to have intuitive meaning, e.g., SmsUnsupportedError, but can also be spelled out in the schema doc.
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Internal, Attempts API, Update in tracking event