LG-6308: Show in-person step indicator in initial steps#6833
Conversation
**Why**: It's expected that the step indicator should update to reflect in-person steps as soon as the user opts to verify in-person, which technically occurs while the user is still at the document capture step. changelog: Upcoming Features, In-person proofing, Show correct step indicator at each step
| ].filter(Boolean) as FormStep[]); | ||
|
|
||
| const stepIndicatorPath = | ||
| stepName && ['location', 'prepare', 'switch_back'].includes(stepName) |
There was a problem hiding this comment.
it would be cool if we had more static steps so we could do like LocationStep.name, PrepareStep.name, SwitchBackStep.name etc but looking at the step definitions, that is definitely a task for another time
There was a problem hiding this comment.
it would be cool if we had more static steps so we could do like
LocationStep.name,PrepareStep.name,SwitchBackStep.nameetc but looking at the step definitions, that is definitely a task for another time
Hm, yeah, I can see how that would be nice to have. Technically the step definitions are already an object from which we could reference step.name, and in the FSMv2 flow we do treat those objects as first-class exports, but we haven't really done that here. It could also be nice to collapse it so that the properties are assigned to the React component, but that may add some confusion, and historically I've had a hard time with TypeScript tolerating custom properties on functions.
| password_confirm: 'secure_account', | ||
| personal_key: 'secure_account', | ||
| personal_key_confirm: 'secure_account', |
There was a problem hiding this comment.
Want to check my understanding here: when the user proceeds through the in-person pages and gets back to the password confirm page, when FSM v2 is enabled, the user will be back in the DEFAULT verify flow path?
There was a problem hiding this comment.
That's correct for now, yes, and would be something we want to change. I'll keep that in mind as I implement the remainder of the work for this ticket, since this pull request was primarily concerned with the first couple steps.
Good to call it out though, thanks 👍
There was a problem hiding this comment.
We may be able to do something similar to what we did to implement the "pending" status for GPO in the FSMv2 flow, where we use the address proofing component. For example, we could consider the document proofing component to determine whether the default or in-person flow should be shown.
There was a problem hiding this comment.
Circling back to this: The revisions needed here are included in #6846.
3 participants
Why: It's expected that the step indicator should update to reflect in-person steps as soon as the user opts to verify in-person, which technically occurs while the user is still at the document capture step.
Screenshots: