Remove FSMv2 configuration override in in-person feature specs#6834
Merged
Remove FSMv2 configuration override in in-person feature specs#6834
Conversation
**Why**: The specs should pass regardless of the configured value, as in-person proofing does not depend on FSMv2. Additionally, we should expect that the default value is the more commonly-desired value (and likely matches the production experience). [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The specs should pass regardless of the configured value, as in-person proofing does not depend on FSMv2 and shouldn't be concerned with the configuration. Additionally, we should expect that the default value is the more commonly-desired value (and likely matches the production experience).
I expect this is likely a hold-over from before #6635 where in-person proofing only supported FSMv2.