LG-6970 create inherited proofing basic landing page#6823
Conversation
jscodefix
requested review from
gangelo,
holytoastr,
rnagilla-gsa and
sheldon-b
holytoastr
added
the
inherited proofing
Could you share more context behind this? Personally, I would have expected it to be feature-flagged, since it's not intended to be ready for production usage yet. |
changelog: Improvements, inherited proofing, Create basic landing page
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM after adding the non-English content 👍
| voip_check: true | ||
| voip_block: true | ||
| voip_allowed_phones: '[]' | ||
| inherited_proofing_va_base_url: 'https://staging-api.va.gov' |
| <%= f.button :button, | ||
| t('inherited_proofing.buttons.continue'), | ||
| type: :submit, | ||
| class: 'usa-button--big usa-button--wide' %> |
There was a problem hiding this comment.
I suggest using the submit helper here, which bakes in the standard conventions of a submit button:
| <%= f.button :button, | |
| t('inherited_proofing.buttons.continue'), | |
| type: :submit, | |
| class: 'usa-button--big usa-button--wide' %> | |
| <%= f.submit t('inherited_proofing.buttons.continue') %> |
| <%= simple_form_for :inherited_proofing, | ||
| url: url_for, | ||
| method: 'put', | ||
| html: { autocomplete: 'off', class: 'margin-y-5 js-consent-continue-form' } do |f| %> |
There was a problem hiding this comment.
The js-consent-continue-form class is only relevant for the unsupervised proofing "Consent" screen, so I wouldn't expect to see it here.
| html: { autocomplete: 'off', class: 'margin-y-5 js-consent-continue-form' } do |f| %> | |
| html: { autocomplete: 'off', class: 'margin-y-5' } do |f| %> |
| es: | ||
| inherited_proofing: | ||
| buttons: | ||
| continue: replaceme |
There was a problem hiding this comment.
Will we create a ticket to replace these, if one doesn't already exist? Asking since I recall instances in the past where placeholder content persisted longer than we had intended it to.
There was a problem hiding this comment.
There's already a ticket and it's in this new sprint! ✌️
There was a problem hiding this comment.
Yes, there is a follow-on story (in the next sprint) for adding the translations. Our team is figuring out the required stories and ordering. Requiring the translations up-front, is kind-of a pain. Maybe the answer (in this case) is to create the page without any translation content (including English, ugg!).
holytoastr
left a comment
holytoastr
left a comment
There was a problem hiding this comment.
Thanks for walking me through the code the other day!
5 participants
The objective is to create a single landing page with minimal code, that used the FSM (v2) methodology.
technical notes on creating the inherited_proofing_controller.rb and use of FSM (flow state machine):
:confirm_two_factor_authenticated, :redirect_if_pending_in_person_enrollment, :redirect_if_pending_profile,
:extend_timeout_using_meta_refresh_for_select_paths, :redirect_if_flow_completed, :override_document_capture_step_csp,
:update_if_skipping_upload, :check_for_outage, :override_csp_for_threat_metrix