Skip to content

LG-7173 Sorry there was a problem with proofing page#6866

Merged
theabrad merged 11 commits intomainfrom
lg-7173-sorry-for-profile-proofing
Aug 30, 2022
Merged

LG-7173 Sorry there was a problem with proofing page#6866
theabrad merged 11 commits intomainfrom
lg-7173-sorry-for-profile-proofing

Conversation

@theabrad
Copy link
Contributor

Why?

Adding a page for when proofing from ThreatMetrix fails.

@theabrad theabrad requested a review from a team August 29, 2022 20:22
Comment on lines +86 to +87
fail_html: 'Please <a href="%{contact_form}">fill out our contact form</a> and
enter the code <b>LG99</b> in the detail field.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's turn this code into a config value and put a fake one in the config. I would like to make sure people don't read our source code to find a way to escalate/shortcut support

warning: Please check the information you entered and try again. Common mistakes
are an incorrect Social Security number or ZIP Code.
setup:
fail_html: 'Please <a href="%{contact_form}">fill out our contact form</a> and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also in other places, when we embed a link inside i18n, i'd make the entire thing the placeholder, and then build the link using link_to in the template"

Suggested change
fail_html: 'Please <a href="%{contact_form}">fill out our contact form</a> and
fail_html: 'Please %{contact_form_link} and

and then like in the erb

t('setup.fail_html', contact_form_link(link_to('....'))

class SetupErrorsController < ApplicationController
before_action :confirm_two_factor_authenticated

def show
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zachmargolis Should we have an analytics event here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that seems like a great idea! maybe a good follow-up PR if we want

and we might want to find a way to reuse RedirectController (maybe subclass it like we do for others) so we can tell how often users actually link the help center link?

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theabrad theabrad merged commit a20d052 into main Aug 30, 2022
@theabrad theabrad deleted the lg-7173-sorry-for-profile-proofing branch August 30, 2022 20:32
@aduth aduth mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants