Use non-hashed SSN param, removed hashed version#6854
Merged
Conversation
zachmargolis
approved these changes
Aug 26, 2022
| "service_type": "all", | ||
| "session_id": "UNIQUE_SESSION_ID", | ||
| "ssn_hash": "15e2b0d3c33891ebb0f1ef609ec419420c20e320ce94c65fbc8c3312448eb225", | ||
| "national_id_number": "123456789", |
Contributor
There was a problem hiding this comment.
(not a blocker) do you think this would be easier to keep in sync if we removed it as a fixture file and inlined it in the spec?
Contributor
Author
There was a problem hiding this comment.
I guess a little, because it's moderately easier to determine what specs to run if the data is right in the relevant spec. But I don't think I want to change it now.
stevegsa
reviewed
Aug 26, 2022
| @@ -17,7 +17,8 @@ | |||
| "policy": "test-policy", | |||
Contributor
There was a problem hiding this comment.
looks good. not a blocker but we might want to update the sample response here which has ssn_hash_result : spec/fixtures/proofing/lexis_nexis/ddp/successful_response.json
Contributor
Author
There was a problem hiding this comment.
made some updates to it!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Per LexisNexis email on 19 August 2022 we should use the
national_id_numberparam instead of thessn_hashparam.How: I have replaced params in the VerificationRequest and fixture file, and added
national_id_typeper the documentation.changelog: Internal, ThreatMetrix API, Use non-hashed param
LG-7384