Update JavaScript tests for cross-version compatibility (14, 16)#6845
Merged
Update JavaScript tests for cross-version compatibility (14, 16)#6845
Conversation
**Why**: As a precursor to #6841, in order to prevent timing issues between upgrading to Node.js v16 in the IdP and in the GitLab CI runner, update specs so that they pass in the current (14) and upgraded (16) versions. changelog: Internal, Build Tooling, Upgrade Node.js to v16
aduth
commented
Aug 26, 2022
|
|
||
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| 'lg-time': TimeElement; |
Contributor
Author
There was a problem hiding this comment.
It's a bit non-obvious, but what this is doing is making it so that the createElement call in the spec will have the current inferred return type based on document.createElement so that the reference to element.formatter doesn't produce a type error.
| Before | After |
|---|---|
 |
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: As a precursor to #6841, in order to prevent timing issues between upgrading to Node.js v16 in the IdP and in the GitLab CI runner, update specs so that they pass in the current (14) and upgraded (16) versions.
Testing Instructions:
Ensure tests pass in Node.js v14 and Node.js v16: