Rescue more generic pinpoint error#6835
Merged
mitchellhenke merged 1 commit intomainfrom Aug 24, 2022
Merged
Conversation
**Why**: because other errors were slipping through and not being rescued correctly changelog: Bug fixes, Multi-factor authentication, handle errors from vendors better
mitchellhenke
approved these changes
Aug 24, 2022
zachmargolis
commented
Aug 24, 2022
| break if response | ||
| rescue Seahorse::Client::NetworkingError, | ||
| Aws::Pinpoint::Errors::InternalServerErrorException => error | ||
| Aws::Pinpoint::Errors::ServiceError => error |
Contributor
Author
There was a problem hiding this comment.
related, we do this correctly elsewhere:
mitchellhenke
pushed a commit
that referenced
this pull request
Aug 24, 2022
**Why**: because other errors were slipping through and not being rescued correctly changelog: Bug fixes, Multi-factor authentication, handle errors from vendors better
Merged
zachmargolis
added a commit
that referenced
this pull request
Aug 25, 2022
**Why**: because other errors were slipping through and not being rescued correctly changelog: Bug fixes, Multi-factor authentication, handle errors from vendors better (cherry picked from commit b31b442)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: because other errors were slipping through and
not being rescued correctly
changelog: Bug fixes, Multi-factor authentication, handle errors from vendors better
See: https://one.newrelic.com/nr1-core/errors/overview/MTM3NjM3MHxBUE18QVBQTElDQVRJT058NTIxMzY4NTg?account=1376370&duration=1800000&state=37783449-3874-df80-5a9f-08fc1def99cb