LG-7084: (And LG-7335) Add tracking for forgot password email sent event#6799
Merged
LG-7084: (And LG-7335) Add tracking for forgot password email sent event#6799
Conversation
changelog: Internal, Account Recovery, Add tracking for forgot password email sent event (LG-7084)
jc-gsa
commented
Aug 19, 2022
| event = PushNotification::RecoveryActivatedEvent.new(user: user) | ||
| PushNotification::HttpPush.deliver(event) | ||
|
|
||
| irs_params[:success] = true |
Contributor
Author
There was a problem hiding this comment.
It's worth noting that the success is presumed here. The email might be delivered async.
jc-gsa
force-pushed
the
LG-7084-forgot-password-email-sent-event
branch
from
1016371 to
6e48ace
Compare
jc-gsa
force-pushed
the
LG-7084-forgot-password-email-sent-event
branch
from
ed347dc to
e547d3e
Compare
jc-gsa
commented
Aug 22, 2022
jc-gsa
changed the title
jc-gsa
force-pushed
the
LG-7084-forgot-password-email-sent-event
branch
from
e471dea to
c672b26
Compare
jc-gsa
changed the title
…ix conflicts # Conflicts: # app/services/irs_attempts_api/tracker_events.rb # spec/controllers/users/reset_passwords_controller_spec.rb
jc-gsa
force-pushed
the
LG-7084-forgot-password-email-sent-event
branch
from
5e344e8 to
274d3fd
Compare
jc-gsa
force-pushed
the
LG-7084-forgot-password-email-sent-event
branch
from
aa52f0e to
1546cd8
Compare
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.