Clarify email delivery in local development#6863
Merged
Conversation
From some anecdotal feedback I've heard from developers: - Some have expected that the application would send real emails - Clarify that the application does not send real emails - Some would test email template changes by going through the real flows - Clarify that Rails template previews exist to simplify this process changelog: Internal, Documentation, Improve onboarding documentation for application emails
See: #6863 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From some anecdotal feedback I've heard from developers:
To better emphasize the common workflows, I also chose to remove some of the details around running Mailcatcher on a different host or port. I think this could be useful information for someone at some point, but I don't think I've ever used it in my time on the program, so it felt like a detail that could be omitted from the top-level documentation.