LG-7096 add Event: IDV Doc auth upload submitted#6820
Conversation
changelog: Internal, Attempts API, Track additional events
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
I'm not too familiar with the proofing process so I might let someone more familiar leave an actual approval.
I left a couple small comments musing about things, which shouldn't be construed as required changes. The code looks excellent.
|
|
||
| expect(@irs_attempts_api_tracker).to receive(:track_event).with( | ||
| :idv_document_upload_submitted, | ||
| success: true, |
There was a problem hiding this comment.
I think I'm questioning existing logic, not your code, but -- it's valid to have this many fields blank?
|
(Adding @18F/identity-agnes as a requested reviewer) |
| service_provider: current_sp, | ||
| analytics: analytics, | ||
| uuid_prefix: current_sp&.app_id, | ||
| irs_attempts_api_tracker: irs_attempts_api_tracker, |
There was a problem hiding this comment.
There are currently two implementations for document capture image submission. This is the "synchronous" implementation. The asynchronous implementation isn't yet shipped, and is triggered through Api::Verify::DocumentCaptureController. Will we want to log the event there as well?
There was a problem hiding this comment.
I believe we will want to track the asynchronous implementation as well. imo. if we plan to have it turned on for IRS.
There was a problem hiding this comment.
@mdiarra3 should we imp async event in this PR and Jira ticket? Or should we create a new ticket for this? What would you suggest?
There was a problem hiding this comment.
I'd do both in the same PR if it's easy
There was a problem hiding this comment.
not an easy :D, it is enqueuing(DocumentProofingJob) background job and there we need to create irs_attempts_api_tracker instance like (analytics = build_analytics(dcs))
There was a problem hiding this comment.
ok, seems like a good candidate for a follow-up then
There was a problem hiding this comment.
Hi @aduth can you help me with how i can test this asynchronous scenario in my local?
There was a problem hiding this comment.
Circling back to this -- I'd cast another vote for filing a followup story for later. That lets us get this one closed out, and we can come back to the trickier async event separately. The fact that the async version hasn't shipped feels like further reason to separate it out.
There was a problem hiding this comment.
@olatifflexion You can add the following to config/application.yml:
doc_auth_enable_presigned_s3_urls: true
5 participants
changelog: Internal, Attempts API, Track additional events