Skip to content

LG-7397 - Bugfix: Moved rate_limited events to be called before sign out.#6862

Merged
Rwolfe-Nava merged 5 commits intomainfrom
lg7397-bugfix-move-rate-limit-events-before-logout
Aug 30, 2022
Merged

LG-7397 - Bugfix: Moved rate_limited events to be called before sign out.#6862
Rwolfe-Nava merged 5 commits intomainfrom
lg7397-bugfix-move-rate-limit-events-before-logout

Conversation

@Rwolfe-Nava
Copy link
Contributor

@Rwolfe-Nava Rwolfe-Nava commented Aug 29, 2022

Summary of changes

  1. Moved rate_limited events to be fired before sign out happens, so that session remains valid and they get stored in redis properly by the tracker.
  2. Removed the success attribute from mfa_login_phone_otp_sent_rate_limited and mfa_enroll_phone_otp_sent_rate_limited for consistency with other rate_limited events.
  3. Changed parameter type to mfa_device_type to match schema and for consistency between events

changelog: Internal, Attempts API, Bugfix events

@Rwolfe-Nava Rwolfe-Nava merged commit 7c34618 into main Aug 30, 2022
@Rwolfe-Nava Rwolfe-Nava deleted the lg7397-bugfix-move-rate-limit-events-before-logout branch August 30, 2022 16:01
@aduth aduth mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants