Add specs to make sure mock/real proofers stay in sync#6853
Merged
zachmargolis merged 5 commits intomainfrom Aug 29, 2022
Merged
Add specs to make sure mock/real proofers stay in sync#6853zachmargolis merged 5 commits intomainfrom
zachmargolis merged 5 commits intomainfrom
Conversation
zachmargolis
commented
Aug 26, 2022
zachmargolis
force-pushed
the
margolis-mock-vs-real
branch
from
6b6affa to
0884f0c
Compare
zachmargolis
commented
Aug 26, 2022
stevegsa
reviewed
Aug 26, 2022
Contributor
There was a problem hiding this comment.
my only worry with this is some flow that doesn't adequately set the uuid but it makes sense that if the other proofers have it mandatory it logically should be there always because address comes after instant verify. with hybrid flow it's effective_user so there is a little magic but i believe we are ok :-)
Contributor
Author
There was a problem hiding this comment.
This was just a true-up to match the PhoneFinder proofer, if it was optional there, it would be optional here
zachmargolis
force-pushed
the
margolis-mock-vs-real
branch
from
f13e412 to
4fac235
Compare
aduth
approved these changes
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(adding in Team Ada since this might help your team too)