replace transmute by raw pointer cast #117266

RalfJung · 2023-10-27T05:52:13Z

Now that #113257 is fixed we can finally do this. :)

rustbot · 2023-10-27T05:52:21Z

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

thomcc · 2023-10-27T05:53:46Z

LGTM

@bors r+

bors · 2023-10-27T05:53:48Z

📌 Commit f71e950 has been approved by thomcc

It is now in the queue for this repository.

thomcc · 2023-10-27T06:00:07Z

r=me with green ci.

RalfJung · 2023-10-27T06:46:38Z

@bors r=thomcc

bors · 2023-10-27T06:46:40Z

📌 Commit b3f7f4d has been approved by thomcc

It is now in the queue for this repository.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#114998 (feat(docs): add cargo-pgo to PGO documentation 📝) - rust-lang#116868 (Tweak suggestion span for outer attr and point at item following invalid inner attr) - rust-lang#117240 (Fix documentation typo in std::iter::Iterator::collect_into) - rust-lang#117241 (Stash and cancel cycle errors for auto trait leakage in opaques) - rust-lang#117262 (Create a new ConstantKind variant (ZeroSized) for StableMIR) - rust-lang#117266 (replace transmute by raw pointer cast) r? `@ghost` `@rustbot` modify labels: rollup

jackh726 · 2023-10-27T12:10:18Z

library/std/src/thread/mod.rs

+            unsafe { mem::transmute::<Box<dyn FnOnce() + 'a>, Box<dyn FnOnce() + 'static>>(main) };
+        #[cfg(not(bootstrap))]
+        let main = unsafe { Box::from_raw(Box::into_raw(main) as *mut (dyn FnOnce() + 'static)) };
+
        Ok(JoinInner {
            // SAFETY:


This SAFETY comment should probably be moved above?

Not quite, that comment is specific to what imp::Thread::new does.. but we should probably forward-reference it from here: #117281

Rollup merge of rust-lang#117266 - RalfJung:cast-not-transmute, r=thomcc replace transmute by raw pointer cast Now that rust-lang#113257 is fixed we can finally do this. :)

std::thread : add SAFETY comment I forgot to add this in rust-lang#117266.

Rollup merge of rust-lang#117281 - RalfJung:thread-safety, r=thomcc std::thread : add SAFETY comment I forgot to add this in rust-lang#117266.

rustbot assigned thomcc Oct 27, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 27, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2023

This comment has been minimized.

Sign in to view

replace transmute by raw pointer cast

b3f7f4d

RalfJung force-pushed the cast-not-transmute branch from f71e950 to b3f7f4d Compare October 27, 2023 06:02

matthiaskrgr mentioned this pull request Oct 27, 2023

Rollup of 6 pull requests #117272

Merged

jackh726 reviewed Oct 27, 2023

View reviewed changes

bors merged commit 2fdac63 into rust-lang:master Oct 27, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 27, 2023

RalfJung deleted the cast-not-transmute branch October 27, 2023 13:10

RalfJung mentioned this pull request Oct 27, 2023

std::thread : add SAFETY comment #117281

Merged

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 27, 2023

Rollup merge of rust-lang#117281 - RalfJung:thread-safety, r=thomcc

f9d62a8

std::thread : add SAFETY comment I forgot to add this in rust-lang#117266.

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2023

Unrolled build for rust-lang#117281

51ca741

Rollup merge of rust-lang#117281 - RalfJung:thread-safety, r=thomcc std::thread : add SAFETY comment I forgot to add this in rust-lang#117266.

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

replace transmute by raw pointer cast #117266

replace transmute by raw pointer cast #117266

RalfJung commented Oct 27, 2023

rustbot commented Oct 27, 2023

thomcc commented Oct 27, 2023

bors commented Oct 27, 2023

This comment has been minimized.

thomcc commented Oct 27, 2023

RalfJung commented Oct 27, 2023

bors commented Oct 27, 2023

jackh726 Oct 27, 2023

RalfJung Oct 27, 2023

replace transmute by raw pointer cast #117266

replace transmute by raw pointer cast #117266

Conversation

RalfJung commented Oct 27, 2023

rustbot commented Oct 27, 2023

thomcc commented Oct 27, 2023

bors commented Oct 27, 2023

This comment has been minimized.

thomcc commented Oct 27, 2023

RalfJung commented Oct 27, 2023

bors commented Oct 27, 2023

jackh726 Oct 27, 2023

Choose a reason for hiding this comment

RalfJung Oct 27, 2023

Choose a reason for hiding this comment