Properly account for self ty in method disambiguation suggestion

[estebank]

Fix #116703.

[rustbot]

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

[compiler-errors]

r=me

[estebank]

@compiler-errors added a slight rewording to existing suggestions so that all related suggestions use the same text.

@bors r=compiler-errors

[bors]

📌 Commit 01de9a6 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

☔ The latest upstream changes (presumably #116804) made this pull request unmergeable. Please resolve the merge conflicts.

[estebank]

@bors r=compiler-errors

[bors]

📌 Commit 890e92f has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 890e92f with merge b9832e7...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing b9832e7 to master...

[rust-timer]

Finished benchmarking commit (b9832e7): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.9%	[-3.9%, -3.9%]	1
Improvements ✅ (secondary)	-2.5%	[-5.0%, -1.2%]	3
All ❌✅ (primary)	-3.9%	[-3.9%, -3.9%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.005s -> 629.781s (-0.19%)
Artifact size: 304.02 MiB -> 303.98 MiB (-0.01%)