Suggest unwrap/expect for let binding type mismatch #116841

chenyukang · 2023-10-17T09:39:07Z

Found it when investigating #116738
I'm not sure whether it's a good style to suggest unwrap, seems it's may helpful for newcomers.

#116738 needs another fix to improve it.

rustbot · 2023-10-17T09:39:15Z

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

tests/ui/lifetimes/issue-26638.stderr

b-naber · 2023-10-24T16:19:49Z

compiler/rustc_hir_typeck/src/demand.rs

@@ -954,6 +955,85 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
        );
    }

+    pub(crate) fn suggest_missing_unwrap_expect(


can you move this to compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs?

seems there are several other functions we may need to move :)

b-naber · 2023-10-24T17:26:38Z

Thanks. Yeah some of those other suggest functions could be moved too.

@bors r+ rollup

bors · 2023-10-24T17:26:40Z

📌 Commit f3d20be has been approved by b-naber

It is now in the queue for this repository.

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#116094 (Introduce `-C instrument-coverage=branch` to gate branch coverage) - rust-lang#116396 (Migrate diagnostics in `rustc_hir_analysis/src/coherence/orphan.rs`) - rust-lang#116714 (Derive `Ord`, `PartialOrd` and `Hash` for `SocketAddr*`) - rust-lang#116792 (Avoid unnecessary renumbering during borrowck) - rust-lang#116841 (Suggest unwrap/expect for let binding type mismatch) - rust-lang#116943 (Add target features for LoongArch) - rust-lang#117010 (Add method to convert internal to stable constructs) - rust-lang#117127 (Remove `#[allow(incomplete_features)]` from RPITIT/AFIT tests) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116841 - chenyukang:yukang-suggest-unwrap-expect, r=b-naber Suggest unwrap/expect for let binding type mismatch Found it when investigating rust-lang#116738 I'm not sure whether it's a good style to suggest `unwrap`, seems it's may helpful for newcomers. rust-lang#116738 needs another fix to improve it.

…-suggestions, r=compiler-errors Refactor: move suggestion functions from demand to suggestions follow-up from rust-lang#116841 (comment)

…ck-suggestions, r=compiler-errors Refactor: move suggestion functions from demand to suggestions follow-up from rust-lang#116841 (comment)

Rollup merge of rust-lang#117401 - chenyukang:yukang-cleanup-hir-typeck-suggestions, r=compiler-errors Refactor: move suggestion functions from demand to suggestions follow-up from rust-lang#116841 (comment)

…tions, r=compiler-errors Refactor: move suggestion functions from demand to suggestions follow-up from rust-lang/rust#116841 (comment)

rustbot assigned b-naber Oct 17, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2023

chenyukang force-pushed the yukang-suggest-unwrap-expect branch from e1a03a1 to da907ec Compare October 17, 2023 09:40

fmease reviewed Oct 17, 2023

View reviewed changes

tests/ui/lifetimes/issue-26638.stderr Outdated Show resolved Hide resolved

chenyukang force-pushed the yukang-suggest-unwrap-expect branch 6 times, most recently from 66af0cb to 4e9d93f Compare October 18, 2023 01:58

b-naber reviewed Oct 24, 2023

View reviewed changes

suggest unwrap/expect for let binding type mismatch

f3d20be

chenyukang force-pushed the yukang-suggest-unwrap-expect branch from 4e9d93f to f3d20be Compare October 24, 2023 16:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2023

matthiaskrgr mentioned this pull request Oct 24, 2023

Rollup of 8 pull requests #117135

Merged

bors merged commit 7a0a2d2 into rust-lang:master Oct 24, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 24, 2023

compiler-errors mentioned this pull request Oct 25, 2023

ice: already mutably borrowed: BorrowError #117144

Closed

chenyukang mentioned this pull request Oct 30, 2023

Refactor: move suggestion functions from demand to suggestions #117401

Merged

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

3tilley mentioned this pull request Nov 7, 2023

Compiler should suggest expect/unwrap before the suggestion to remove the last method call #117669

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suggest unwrap/expect for let binding type mismatch #116841

Suggest unwrap/expect for let binding type mismatch #116841

chenyukang commented Oct 17, 2023 •

edited

Loading

rustbot commented Oct 17, 2023

b-naber Oct 24, 2023

chenyukang Oct 24, 2023

chenyukang Oct 24, 2023

b-naber commented Oct 24, 2023

bors commented Oct 24, 2023

Suggest unwrap/expect for let binding type mismatch #116841

Suggest unwrap/expect for let binding type mismatch #116841

Conversation

chenyukang commented Oct 17, 2023 • edited Loading

rustbot commented Oct 17, 2023

b-naber Oct 24, 2023

Choose a reason for hiding this comment

chenyukang Oct 24, 2023

Choose a reason for hiding this comment

chenyukang Oct 24, 2023

Choose a reason for hiding this comment

b-naber commented Oct 24, 2023

bors commented Oct 24, 2023

chenyukang commented Oct 17, 2023 •

edited

Loading