Disable missing_copy_implementations lint on non_exhaustive types #116812

rmehri01 · 2023-10-16T18:10:56Z

Fixes #116766

rustbot · 2023-10-16T18:11:04Z

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

compiler/rustc_lint/src/builtin.rs

petrochenkov · 2023-10-17T15:25:37Z

r=me after addressing #116812 (comment) and squashing commits.

use is_variant_list_non_exhaustive/is_field_list_non_exhaustive remove unused tcx inline non_exhaustive def/variant check

petrochenkov · 2023-10-17T19:30:40Z

@bors r+ rollup

bors · 2023-10-17T19:30:42Z

📌 Commit a8e7e79 has been approved by petrochenkov

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - rust-lang#116812 (Disable missing_copy_implementations lint on non_exhaustive types) - rust-lang#116856 (Disable effects in libcore again) - rust-lang#116865 (Suggest constraining assoc types in more cases) - rust-lang#116870 (Don't compare host param by name) - rust-lang#116879 (revert rust-lang#114586) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116812 - rmehri01:missing_copy_implementations_non_exhaustive, r=petrochenkov Disable missing_copy_implementations lint on non_exhaustive types Fixes rust-lang#116766

rustbot assigned petrochenkov Oct 16, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 16, 2023

petrochenkov reviewed Oct 17, 2023

View reviewed changes

compiler/rustc_lint/src/builtin.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2023

petrochenkov reviewed Oct 17, 2023

View reviewed changes

compiler/rustc_lint/src/builtin.rs Outdated Show resolved Hide resolved

disable missing_copy_implementations lint on non_exhaustive types

a8e7e79

use is_variant_list_non_exhaustive/is_field_list_non_exhaustive remove unused tcx inline non_exhaustive def/variant check

rmehri01 force-pushed the missing_copy_implementations_non_exhaustive branch from 45dd973 to a8e7e79 Compare October 17, 2023 15:34

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 17, 2023

aliemjay mentioned this pull request Oct 18, 2023

Rollup of 5 pull requests #116885

Merged

bors merged commit 0653d7e into rust-lang:master Oct 18, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 18, 2023

rmehri01 deleted the missing_copy_implementations_non_exhaustive branch October 18, 2023 14:50

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable missing_copy_implementations lint on non_exhaustive types #116812

Disable missing_copy_implementations lint on non_exhaustive types #116812

rmehri01 commented Oct 16, 2023

rustbot commented Oct 16, 2023

petrochenkov commented Oct 17, 2023

petrochenkov commented Oct 17, 2023

bors commented Oct 17, 2023

Disable missing_copy_implementations lint on non_exhaustive types #116812

Disable missing_copy_implementations lint on non_exhaustive types #116812

Conversation

rmehri01 commented Oct 16, 2023

rustbot commented Oct 16, 2023

petrochenkov commented Oct 17, 2023

petrochenkov commented Oct 17, 2023

bors commented Oct 17, 2023