On object safety error, mention new enum as alternative #117132

estebank · 2023-10-24T16:45:19Z

When we encounter a dyn Trait that isn't object safe, look for its implementors. If there's one, mention using it directly If there are less than 9, mention the possibility of creating a new enum and using that instead.

Fix #80194.

rustbot · 2023-10-24T16:45:27Z

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

tests/ui/coherence/coherence-impl-trait-for-trait-object-safe.stderr

tests/ui/generic-associated-types/issue-76535.base.stderr

petrochenkov · 2023-10-28T09:08:04Z

r=me after squashing commits.
@rustbot author

When we encounter a `dyn Trait` that isn't object safe, look for its implementors. If there's one, mention using it directly If there are less than 9, mention the possibility of creating a new enum and using that instead. Account for object unsafe `impl Trait on dyn Trait {}`. Make a distinction between public and sealed traits. Fix rust-lang#80194.

estebank · 2023-10-30T00:05:28Z

@bors r=petrochenkov

bors · 2023-10-30T00:05:31Z

📌 Commit 8c04999 has been approved by petrochenkov

It is now in the queue for this repository.

bors · 2023-10-30T06:03:01Z

⌛ Testing commit 8c04999 with merge 7ebea0f...

On object safety error, mention new enum as alternative When we encounter a `dyn Trait` that isn't object safe, look for its implementors. If there's one, mention using it directly If there are less than 9, mention the possibility of creating a new enum and using that instead. Fix rust-lang#80194.

bors · 2023-10-30T10:18:01Z

💥 Test timed out

rust-log-analyzer · 2023-10-30T10:59:59Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

estebank · 2023-10-30T14:25:22Z

@bors retry

On object safety error, mention new enum as alternative When we encounter a `dyn Trait` that isn't object safe, look for its implementors. If there's one, mention using it directly If there are less than 9, mention the possibility of creating a new enum and using that instead. Fix rust-lang#80194.

…llaumeGomez Rollup of 11 pull requests Successful merges: - rust-lang#112463 (rustdoc: elide cross-crate default generic arguments) - rust-lang#117068 (Clean up `compiler/rustc*/Cargo.toml`) - rust-lang#117132 (On object safety error, mention new enum as alternative) - rust-lang#117317 (share some track_caller logic between interpret and codegen) - rust-lang#117356 (Add support for mipsel-unknown-netbsd, 32-bit LE mips.) - rust-lang#117357 (Rename a few remaining references to abort terminator) - rust-lang#117370 (C-variadic error improvements) - rust-lang#117376 (More `rustc_interface` cleanups) - rust-lang#117383 (improve and fix `x install`) - rust-lang#117390 (Fix unused variables lint issue for args in macro) - rust-lang#117395 (Fix missing leading space in suggestion) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117132 - estebank:issue-80194, r=petrochenkov On object safety error, mention new enum as alternative When we encounter a `dyn Trait` that isn't object safe, look for its implementors. If there's one, mention using it directly If there are less than 9, mention the possibility of creating a new enum and using that instead. Fix rust-lang#80194.

alilleybrinker · 2023-10-31T14:44:21Z

Wow, thanks @estebank for implementing this! 🎉

rustbot assigned petrochenkov Oct 24, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 24, 2023

petrochenkov reviewed Oct 26, 2023

View reviewed changes

tests/ui/coherence/coherence-impl-trait-for-trait-object-safe.stderr Outdated Show resolved Hide resolved

tests/ui/generic-associated-types/issue-76535.base.stderr Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2023

estebank added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2023

This comment was marked as outdated.

Sign in to view

estebank force-pushed the issue-80194 branch from 2aad509 to 44f0b7f Compare October 26, 2023 23:48

This comment has been minimized.

Sign in to view

estebank force-pushed the issue-80194 branch from 89a05c6 to b932349 Compare October 27, 2023 23:54

petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 28, 2023

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2023

estebank force-pushed the issue-80194 branch from b932349 to 8c04999 Compare October 30, 2023 00:04

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 30, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 30, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2023

This was referenced Oct 30, 2023

Rollup of 12 pull requests #117404

Closed

Rollup of 11 pull requests #117405

Merged

bors merged commit 95de91b into rust-lang:master Oct 30, 2023
11 of 12 checks passed

rustbot added this to the 1.75.0 milestone Oct 30, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

estebank deleted the issue-80194 branch November 9, 2023 05:12

matthiaskrgr mentioned this pull request Dec 18, 2023

ice: cannot convert ReLateParam to a region vid #119085

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

On object safety error, mention new enum as alternative #117132

On object safety error, mention new enum as alternative #117132

estebank commented Oct 24, 2023

rustbot commented Oct 24, 2023

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Oct 28, 2023

estebank commented Oct 30, 2023

bors commented Oct 30, 2023

bors commented Oct 30, 2023

bors commented Oct 30, 2023

rust-log-analyzer commented Oct 30, 2023

estebank commented Oct 30, 2023

alilleybrinker commented Oct 31, 2023

On object safety error, mention new enum as alternative #117132

On object safety error, mention new enum as alternative #117132

Conversation

estebank commented Oct 24, 2023

rustbot commented Oct 24, 2023

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Oct 28, 2023

estebank commented Oct 30, 2023

bors commented Oct 30, 2023

bors commented Oct 30, 2023

bors commented Oct 30, 2023

rust-log-analyzer commented Oct 30, 2023

estebank commented Oct 30, 2023

alilleybrinker commented Oct 31, 2023