Typo suggestion to change bindings with leading underscore #116961

estebank · 2023-10-19T22:34:58Z

When encountering a binding that isn't found but has a typo suggestion for a binding with a leading underscore, suggest changing the binding definition instead of the use place.

Fix #60164.

rustbot · 2023-10-19T22:35:07Z

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

oli-obk · 2023-10-20T09:27:48Z

compiler/rustc_resolve/src/diagnostics.rs

+            && suggestion.candidate.as_str().starts_with("_")
+            && snippet == suggestion.candidate.as_str()[1..]


can probably write this as

Suggested change

&& suggestion.candidate.as_str().starts_with("_")

&& snippet == suggestion.candidate.as_str()[1..]

&& let Some(suggestion) = suggestion.candidate.as_str().strip_prefix("_")

&& snippet == suggestion

When encountering a binding that isn't found but has a typo suggestion for a binding with a leading underscore, suggest changing the binding definition instead of the use place. Fix rust-lang#60164.

oli-obk · 2023-10-20T15:59:21Z

@bors r+ rollup

bors · 2023-10-20T15:59:23Z

📌 Commit b0d17f3 has been approved by oli-obk

It is now in the queue for this repository.

Typo suggestion to change bindings with leading underscore When encountering a binding that isn't found but has a typo suggestion for a binding with a leading underscore, suggest changing the binding definition instead of the use place. Fix rust-lang#60164.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#116911 (Suggest relaxing implicit `type Assoc: Sized;` bound) - rust-lang#116961 (Typo suggestion to change bindings with leading underscore) - rust-lang#116964 (Add stable Instance::body() and RustcInternal trait) - rust-lang#116992 (Mention the syntax for `use` on `mod foo;` if `foo` doesn't exist) - rust-lang#116995 (Point at assoc fn definition on type param divergence) Failed merges: - rust-lang#116974 (coverage: Fix inconsistent handling of function signature spans) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#114521 (std: freebsd build update.) - rust-lang#116911 (Suggest relaxing implicit `type Assoc: Sized;` bound) - rust-lang#116917 (coverage: Simplify the injection of coverage statements) - rust-lang#116961 (Typo suggestion to change bindings with leading underscore) - rust-lang#116964 (Add stable Instance::body() and RustcInternal trait) - rust-lang#116974 (coverage: Fix inconsistent handling of function signature spans) - rust-lang#116990 (Mention `into_iter` on borrow errors suggestions when appropriate) - rust-lang#116995 (Point at assoc fn definition on type param divergence) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116961 - estebank:issue-60164, r=oli-obk Typo suggestion to change bindings with leading underscore When encountering a binding that isn't found but has a typo suggestion for a binding with a leading underscore, suggest changing the binding definition instead of the use place. Fix rust-lang#60164.

rustbot assigned oli-obk Oct 19, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 19, 2023

estebank force-pushed the issue-60164 branch from 4bd5f7d to 2d34147 Compare October 19, 2023 22:35

oli-obk reviewed Oct 20, 2023

View reviewed changes

oli-obk approved these changes Oct 20, 2023

View reviewed changes

Typo suggestion to change bindings with leading underscore

b0d17f3

When encountering a binding that isn't found but has a typo suggestion for a binding with a leading underscore, suggest changing the binding definition instead of the use place. Fix rust-lang#60164.

estebank force-pushed the issue-60164 branch from 2d34147 to b0d17f3 Compare October 20, 2023 15:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2023

matthiaskrgr mentioned this pull request Oct 20, 2023

Rollup of 4 pull requests #116994

Closed

matthiaskrgr mentioned this pull request Oct 20, 2023

Rollup of 5 pull requests #117002

Closed

matthiaskrgr mentioned this pull request Oct 21, 2023

Rollup of 8 pull requests #117013

Merged

bors merged commit c5dd84d into rust-lang:master Oct 21, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 21, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

estebank deleted the issue-60164 branch November 9, 2023 05:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Typo suggestion to change bindings with leading underscore #116961

Typo suggestion to change bindings with leading underscore #116961

estebank commented Oct 19, 2023

rustbot commented Oct 19, 2023

oli-obk Oct 20, 2023

oli-obk commented Oct 20, 2023

bors commented Oct 20, 2023

		&& suggestion.candidate.as_str().starts_with("_")
		&& snippet == suggestion.candidate.as_str()[1..]

Typo suggestion to change bindings with leading underscore #116961

Typo suggestion to change bindings with leading underscore #116961

Conversation

estebank commented Oct 19, 2023

rustbot commented Oct 19, 2023

oli-obk Oct 20, 2023

Choose a reason for hiding this comment

oli-obk commented Oct 20, 2023

bors commented Oct 20, 2023