Suggest constraining assoc types in more cases #116865

estebank · 2023-10-17T23:08:56Z

error[E0308]: mismatched types
  --> $DIR/suggest-contraining-assoc-type-because-of-assoc-const.rs:12:21
   |
LL |     const N: C::M = 4u8;
   |                     ^^^ expected associated type, found `u8`
   |
   = note: expected associated type `<C as O>::M`
                         found type `u8`
help: consider constraining the associated type `<C as O>::M` to `u8`
   |
LL | impl<C: O<M = u8>> U<C> for u16 {
   |          ++++++++

rustbot · 2023-10-17T23:09:04Z

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

Fix rust-lang#46969.

compiler-errors · 2023-10-18T00:07:14Z

@bors r+ rollup

bors · 2023-10-18T00:07:16Z

📌 Commit dee86bf has been approved by compiler-errors

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - rust-lang#116812 (Disable missing_copy_implementations lint on non_exhaustive types) - rust-lang#116856 (Disable effects in libcore again) - rust-lang#116865 (Suggest constraining assoc types in more cases) - rust-lang#116870 (Don't compare host param by name) - rust-lang#116879 (revert rust-lang#114586) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116865 - estebank:issue-46969, r=compiler-errors Suggest constraining assoc types in more cases Fix rust-lang#46969. ``` error[E0308]: mismatched types --> $DIR/suggest-contraining-assoc-type-because-of-assoc-const.rs:12:21 | LL | const N: C::M = 4u8; | ^^^ expected associated type, found `u8` | = note: expected associated type `<C as O>::M` found type `u8` help: consider constraining the associated type `<C as O>::M` to `u8` | LL | impl<C: O<M = u8>> U<C> for u16 { | ++++++++ ```

rustbot assigned compiler-errors Oct 17, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2023

This comment has been minimized.

Sign in to view

Suggest constraining assoc types in more cases

dee86bf

Fix rust-lang#46969.

estebank force-pushed the issue-46969 branch from 4b86ebf to dee86bf Compare October 17, 2023 23:50

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2023

aliemjay mentioned this pull request Oct 18, 2023

Rollup of 5 pull requests #116885

Merged

bors merged commit d69cdb2 into rust-lang:master Oct 18, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 18, 2023

lqd mentioned this pull request Oct 26, 2023

ICE: index out of bounds: the len is 2 but the index is 2 #117209

Closed

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

estebank deleted the issue-46969 branch November 9, 2023 05:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suggest constraining assoc types in more cases #116865

Suggest constraining assoc types in more cases #116865

estebank commented Oct 17, 2023

rustbot commented Oct 17, 2023

This comment has been minimized.

compiler-errors commented Oct 18, 2023

bors commented Oct 18, 2023

Suggest constraining assoc types in more cases #116865

Suggest constraining assoc types in more cases #116865

Conversation

estebank commented Oct 17, 2023

rustbot commented Oct 17, 2023

This comment has been minimized.

compiler-errors commented Oct 18, 2023

bors commented Oct 18, 2023