Don't crash on empty match in the `nonexhaustive_omitted_patterns` lint #117034

Nadrieril · 2023-10-21T21:05:46Z

Oops

Fixes #117033

rustbot · 2023-10-21T21:05:54Z

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

Nadrieril · 2023-10-21T21:13:26Z

r? @cjgillot who's already familiar with this from #116734

fmease · 2023-10-21T21:52:06Z

Could you put the “Fix #NNN” part into the PR description to make the issue close automatically once this PR is merged and choose a more descriptive title? Thanks!

cjgillot · 2023-10-21T22:39:37Z

@bors r+

bors · 2023-10-21T22:39:39Z

📌 Commit a134f16 has been approved by cjgillot

It is now in the queue for this repository.

…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#116985 (Use gdb.ValuePrinter tag class) - rust-lang#116989 (Skip test if Unix sockets are unsupported) - rust-lang#117034 (Don't crash on empty match in the `nonexhaustive_omitted_patterns` lint) - rust-lang#117037 (rustdoc book doc example error) r? `@ghost` `@rustbot` modify labels: rollup

Noratrieb · 2023-10-22T09:23:30Z

compiler/rustc_mir_build/src/thir/pattern/usefulness.rs

+    if column.is_empty() {
+        return Vec::new();
+    }
    let ty = column[0].ty();


this could have been get + let-else

let Some(ty) = column.get(0) else { return Vec::new(); }; let ty = ty.ty();

not that it matters though.

Rollup merge of rust-lang#117034 - Nadrieril:fix-117033, r=cjgillot Don't crash on empty match in the `nonexhaustive_omitted_patterns` lint Oops Fixes rust-lang#117033

Fix rust-lang#117033

a134f16

rustbot assigned oli-obk Oct 21, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 21, 2023

Nadrieril mentioned this pull request Oct 21, 2023

ICE: index out of bounds, usefulness #117033

Closed

rustbot assigned cjgillot and unassigned oli-obk Oct 21, 2023

Nadrieril changed the title ~~Fix #117033~~ Don't crash on empty match in the nonexhaustive_omitted_patterns lint Oct 21, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2023

matthiaskrgr mentioned this pull request Oct 22, 2023

Rollup of 4 pull requests #117041

Merged

Noratrieb reviewed Oct 22, 2023

View reviewed changes

bors merged commit 4681eb6 into rust-lang:master Oct 22, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 22, 2023

Nadrieril deleted the fix-117033 branch October 22, 2023 10:30

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Nadrieril added the F-non_exhaustive_omitted_patterns_lint `#![feature(non_exhaustive_omitted_patterns_lint)]` label Dec 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't crash on empty match in the `nonexhaustive_omitted_patterns` lint #117034

Don't crash on empty match in the `nonexhaustive_omitted_patterns` lint #117034

Nadrieril commented Oct 21, 2023 •

edited

Loading

rustbot commented Oct 21, 2023

Nadrieril commented Oct 21, 2023

fmease commented Oct 21, 2023

cjgillot commented Oct 21, 2023

bors commented Oct 21, 2023

Noratrieb Oct 22, 2023

Don't crash on empty match in the nonexhaustive_omitted_patterns lint #117034

Don't crash on empty match in the nonexhaustive_omitted_patterns lint #117034

Conversation

Nadrieril commented Oct 21, 2023 • edited Loading

rustbot commented Oct 21, 2023

Nadrieril commented Oct 21, 2023

fmease commented Oct 21, 2023

cjgillot commented Oct 21, 2023

bors commented Oct 21, 2023

Noratrieb Oct 22, 2023

Choose a reason for hiding this comment

Don't crash on empty match in the `nonexhaustive_omitted_patterns` lint #117034

Don't crash on empty match in the `nonexhaustive_omitted_patterns` lint #117034

Nadrieril commented Oct 21, 2023 •

edited

Loading