Use YYYY-MM-DDTHH_MM_SS as datetime format for ICE dump files

[estebank]

Windows paths do not support :, so use a datetime format in ICE dump paths that Windows will accept.

CC #116809, fix #115180.

[rustbot]

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

[compiler-errors]

Is it possible to add a test for this?

[jyn514]

you could add an // only-windows run-make test that checks the ICE text file exists, but the break rust easter egg bypasses this codepath so it might be hard to get a stable ICE

[estebank]

Added test.

[bors]

☔ The latest upstream changes (presumably #116477) made this pull request unmergeable. Please resolve the merge conflicts.

[petrochenkov]

r=me after rebase.
@rustbot author

[estebank]

@bors r=petrochenkov

[bors]

📌 Commit e1aa5ad has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit e1aa5ad with merge 6d7160c...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 6d7160c to master...

[rust-timer]

Finished benchmarking commit (6d7160c): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.7%	[0.6%, 0.8%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.8%	[1.1%, 3.8%]	5
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-3.4%	[-3.7%, -3.1%]	3
All ❌✅ (primary)	-2.4%	[-2.4%, -2.4%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.3%	[2.5%, 5.6%]	11
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.781s -> 631.187s (0.22%)
Artifact size: 303.98 MiB -> 304.03 MiB (0.01%)