implement C ABI lowering for CSKY #117154

Dirreke · 2023-10-25T05:03:41Z

Reference: CSKY ABI Manual

Reference: Clang CSKY lowering code

bjorn3 · 2023-10-25T10:55:09Z

compiler/rustc_target/src/abi/call/csky.rs

+    if arg.layout.is_aggregate() {
+        let total = arg.layout.size;
+        if total.bits() > 64 {
+            // We rely on the LLVM backend lowering code to lower passing a scalar larger than 2*XLEN.


I think this comment is misplaced.

bjorn3 · 2023-10-25T10:55:19Z

compiler/rustc_target/src/abi/call/csky.rs

+    // For argument type, the first 4*XLen parts of aggregate will be passed
+    // in registers, and the rest will be passed in stack.
+    // So we can coerce to integers directly and let backend handle it correctly.


Same for this.

bjorn3 · 2023-10-25T10:57:08Z

The Clang abi code is a bit hard to follow, but I think you correctly translated it. You could try abi-cafe to see if there are mismatches. Abi-cafe is not exhaustive, but it should catch a fair amount of abi issues.

LGTM with the comments fixed.

bjorn3 · 2023-10-25T12:46:19Z

@bors r+

bors · 2023-10-25T12:46:21Z

📌 Commit 32339f8 has been approved by bjorn3

It is now in the queue for this repository.

Dirreke · 2023-10-25T14:44:47Z

I tried abi-cafe. However, it seems that it cannot use for cross-compoile now.

bjorn3 · 2023-10-25T14:51:22Z

Right, it uses dlopen of the dylibs to test. Roughly how fast are CSKY processors? Is the perforance more like that of a microcontroller where you would never be able to run rustc on it, is it more like an SBC like a raspberry pi where you could cross-compile rustc for CSKY and then run abi-cafe using said CSKY rustc albeit rather slowly or does it have a fairly decent performance?

Dirreke · 2023-10-25T15:17:32Z

It have a decent performance.

However, there's no gcc host tool on it. The open-source code of gcc is very old too. I will ask the maintainer of the csky if they can give the newest source code or gcc host tool.

(Besides, thanks for your guidance during this period

Dirreke · 2023-10-25T17:26:29Z

I cannot build rustc for csky too. csky-linux-x86_64-gcc-toolchain is based on gcc 6.3.0 and llvm requires that gcc version must be at least 7.4.

Therefore, I won't test the abi with abi-cafe for now. This is enough to compile and run a sufficiently complex program with almost all hardware drivers related operations, mathematical optimization operations and web server.

Thanks all the time!

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#117111 (Remove support for alias `-Z instrument-coverage`) - rust-lang#117141 (Require target features to match exactly during inlining) - rust-lang#117152 (Fix unwrap suggestion for async fn) - rust-lang#117154 (implement C ABI lowering for CSKY) - rust-lang#117159 (Work around the fact that `check_mod_type_wf` may spuriously return `ErrorGuaranteed`) - rust-lang#117163 (compiletest: Display compilation errors in mir-opt tests) - rust-lang#117173 (Make `Iterator` a lang item) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117154 - Dirreke:csky-unknown-linux-gunabiv2, r=bjorn3 implement C ABI lowering for CSKY fix rust-lang/compiler-builtins#551 Reference: [CSKY ABI Manual](https://occ-oss-prod.oss-cn-hangzhou.aliyuncs.com/resource//1695027452256/T-HEAD_800_Series_ABI_Standards_Manual.pdf) Reference: [Clang CSKY lowering code](https://github.com/llvm/llvm-project/blob/4a074f32a6914f2a8d7215d78758c24942dddc3d/clang/lib/CodeGen/Targets/CSKY.cpp#L76-L162) r? `@bjorn3`

rustbot assigned bjorn3 Oct 25, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 25, 2023

bjorn3 reviewed Oct 25, 2023

View reviewed changes

Dirreke force-pushed the csky-unknown-linux-gunabiv2 branch from a130e29 to 32339f8 Compare October 25, 2023 12:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2023

implement C ABI lowering for CSKY

32339f8

matthiaskrgr mentioned this pull request Oct 25, 2023

Rollup of 7 pull requests #117180

Merged

bors merged commit 74c2b98 into rust-lang:master Oct 25, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 25, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

workingjubilee added the O-csky Target: glaCSKY above covers over me~ label May 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement C ABI lowering for CSKY #117154

implement C ABI lowering for CSKY #117154

Dirreke commented Oct 25, 2023 •

edited

Loading

bjorn3 Oct 25, 2023

bjorn3 Oct 25, 2023

bjorn3 commented Oct 25, 2023

bjorn3 commented Oct 25, 2023

bors commented Oct 25, 2023

Dirreke commented Oct 25, 2023

bjorn3 commented Oct 25, 2023

Dirreke commented Oct 25, 2023 •

edited

Loading

Dirreke commented Oct 25, 2023

implement C ABI lowering for CSKY #117154

implement C ABI lowering for CSKY #117154

Conversation

Dirreke commented Oct 25, 2023 • edited Loading

bjorn3 Oct 25, 2023

Choose a reason for hiding this comment

bjorn3 Oct 25, 2023

Choose a reason for hiding this comment

bjorn3 commented Oct 25, 2023

bjorn3 commented Oct 25, 2023

bors commented Oct 25, 2023

Dirreke commented Oct 25, 2023

bjorn3 commented Oct 25, 2023

Dirreke commented Oct 25, 2023 • edited Loading

Dirreke commented Oct 25, 2023

Dirreke commented Oct 25, 2023 •

edited

Loading

Dirreke commented Oct 25, 2023 •

edited

Loading