Suggest assoc fn `new` when trying to build tuple struct with private fields #116858

estebank · 2023-10-17T19:30:21Z

Fix #22488.

rustbot · 2023-10-17T19:30:31Z

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

compiler/rustc_resolve/src/late/diagnostics.rs

petrochenkov · 2023-10-26T15:31:11Z

r=me with the comment updated.
@rustbot author

estebank · 2023-10-26T22:20:19Z

@bors r=petrochenkov

bors · 2023-10-26T22:20:22Z

📌 Commit 1c161b7 has been approved by petrochenkov

It is now in the queue for this repository.

… fields Fix rust-lang#22488.

estebank · 2023-10-26T22:21:20Z

@bors r=petrochenkov

bors · 2023-10-26T22:21:22Z

📌 Commit 87dc85d has been approved by petrochenkov

It is now in the queue for this repository.

Suggest assoc fn `new` when trying to build tuple struct with private fields Fix rust-lang#22488.

Rollup of 5 pull requests Successful merges: - rust-lang#116858 (Suggest assoc fn `new` when trying to build tuple struct with private fields) - rust-lang#116868 (Tweak suggestion span for outer attr and point at item following invalid inner attr) - rust-lang#117025 (Cleanup and improve `--check-cfg` implementation) - rust-lang#117170 (Add support for i586-unknown-netbsd as target.) - rust-lang#117240 (Fix documentation typo in std::iter::Iterator::collect_into) r? `@ghost` `@rustbot` modify labels: rollup

Suggest assoc fn `new` when trying to build tuple struct with private fields Fix rust-lang#22488.

Rollup of 5 pull requests Successful merges: - rust-lang#114998 (feat(docs): add cargo-pgo to PGO documentation 📝) - rust-lang#116858 (Suggest assoc fn `new` when trying to build tuple struct with private fields) - rust-lang#116868 (Tweak suggestion span for outer attr and point at item following invalid inner attr) - rust-lang#117025 (Cleanup and improve `--check-cfg` implementation) - rust-lang#117240 (Fix documentation typo in std::iter::Iterator::collect_into) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2023-10-27T08:17:29Z

⌛ Testing commit 87dc85d with merge e4e3a23...

Suggest assoc fn `new` when trying to build tuple struct with private fields Fix rust-lang#22488.

bors · 2023-10-27T08:23:48Z

💔 Test failed - checks-actions

rust-log-analyzer · 2023-10-27T08:23:58Z

The job x86_64-gnu-stable failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[endgroup]
[TIMING] core::build_steps::tool::ToolBuild { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu }, target: x86_64-unknown-linux-gnu, tool: "tidy", path: "src/tools/tidy", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [], allow_features: "" } -- 25.880
[TIMING] core::build_steps::tool::Tidy { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu }, target: x86_64-unknown-linux-gnu } -- 0.000
tidy check
thread 'deps (.)' panicked at src/tools/tidy/src/deps.rs:389:20:

petrochenkov · 2023-10-27T10:37:24Z

@bors retry

bors · 2023-10-27T12:16:05Z

⌛ Testing commit 87dc85d with merge 6888929...

bors · 2023-10-27T14:09:35Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 6888929 to master...

rust-timer · 2023-10-27T16:18:00Z

Finished benchmarking commit (6888929): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 636.074s -> 635.341s (-0.12%)
Artifact size: 304.47 MiB -> 304.51 MiB (0.01%)

rustbot assigned petrochenkov Oct 17, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2023

This comment has been minimized.

Sign in to view

estebank force-pushed the issue-22488 branch from 0d257bf to e5c15af Compare October 17, 2023 20:35

This comment has been minimized.

Sign in to view

estebank force-pushed the issue-22488 branch from e5c15af to 156183a Compare October 18, 2023 23:02

petrochenkov reviewed Oct 26, 2023

View reviewed changes

compiler/rustc_resolve/src/late/diagnostics.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2023

estebank force-pushed the issue-22488 branch from 156183a to 1c161b7 Compare October 26, 2023 22:19

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2023

Suggest assoc fn new when trying to build tuple struct with private…

87dc85d

… fields Fix rust-lang#22488.

estebank force-pushed the issue-22488 branch from 1c161b7 to 87dc85d Compare October 26, 2023 22:21

TaKO8Ki added a commit to TaKO8Ki/rust that referenced this pull request Oct 27, 2023

Rollup merge of rust-lang#116858 - estebank:issue-22488, r=petrochenkov

31e949e

Suggest assoc fn `new` when trying to build tuple struct with private fields Fix rust-lang#22488.

TaKO8Ki mentioned this pull request Oct 27, 2023

Rollup of 5 pull requests #117255

Closed

TaKO8Ki added a commit to TaKO8Ki/rust that referenced this pull request Oct 27, 2023

Rollup merge of rust-lang#116858 - estebank:issue-22488, r=petrochenkov

9af5c37

Suggest assoc fn `new` when trying to build tuple struct with private fields Fix rust-lang#22488.

TaKO8Ki mentioned this pull request Oct 27, 2023

Rollup of 5 pull requests #117264

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2023

Auto merge of rust-lang#116858 - estebank:issue-22488, r=petrochenkov

e4e3a23

Suggest assoc fn `new` when trying to build tuple struct with private fields Fix rust-lang#22488.

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 27, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 27, 2023

bors merged commit 6888929 into rust-lang:master Oct 27, 2023
12 checks passed

rustbot added this to the 1.75.0 milestone Oct 27, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

estebank deleted the issue-22488 branch November 9, 2023 05:12

kadiwa4 mentioned this pull request Feb 19, 2024

tuple struct expressions with non-visible (private) fields should bias towards suggesting methods #103215

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suggest assoc fn `new` when trying to build tuple struct with private fields #116858

Suggest assoc fn `new` when trying to build tuple struct with private fields #116858

estebank commented Oct 17, 2023

rustbot commented Oct 17, 2023

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Oct 26, 2023

estebank commented Oct 26, 2023

bors commented Oct 26, 2023

estebank commented Oct 26, 2023

bors commented Oct 26, 2023

bors commented Oct 27, 2023

bors commented Oct 27, 2023

rust-log-analyzer commented Oct 27, 2023

petrochenkov commented Oct 27, 2023

bors commented Oct 27, 2023

bors commented Oct 27, 2023

rust-timer commented Oct 27, 2023

Suggest assoc fn new when trying to build tuple struct with private fields #116858

Suggest assoc fn new when trying to build tuple struct with private fields #116858

Conversation

estebank commented Oct 17, 2023

rustbot commented Oct 17, 2023

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Oct 26, 2023

estebank commented Oct 26, 2023

bors commented Oct 26, 2023

estebank commented Oct 26, 2023

bors commented Oct 26, 2023

bors commented Oct 27, 2023

bors commented Oct 27, 2023

rust-log-analyzer commented Oct 27, 2023

petrochenkov commented Oct 27, 2023

bors commented Oct 27, 2023

bors commented Oct 27, 2023

rust-timer commented Oct 27, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Suggest assoc fn `new` when trying to build tuple struct with private fields #116858

Suggest assoc fn `new` when trying to build tuple struct with private fields #116858