Return multiple object-safety violation errors and code improvements to the object-safety check #116401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
| } | ||
| virtual_call_violation_for_method(tcx, trait_def_id, method) | ||
| .iter() | ||
| .all(|v| matches!(v, MethodViolationCode::WhereClauseReferencesSelf)) |
There was a problem hiding this comment.
thanks for doing this, it's so much safer lol
This comment has been minimized.
This comment has been minimized.
oli-obk
approved these changes
Oct 6, 2023
| None | Some(MethodViolationCode::WhereClauseReferencesSelf) => true, | ||
| Some(_) => false, | ||
| } | ||
| virtual_call_violation_for_method(tcx, trait_def_id, method) |
There was a problem hiding this comment.
nit: make violation plural in these functions
oli-obk
added
S-waiting-on-author
rust-cloud-vms
bot
force-pushed
the
vtablin'''
branch
from
cedc4e1
to
ecdbefa
Compare
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for more information. Split off of #114260, since it turned out that the main intent of that PR was wrong.
r? oli-obk