Bump to `stable2503` #711

athei · 2025-05-05T15:04:48Z

Is disabled encointer for now and copied over the weight files from Polkadot SDK to reduce errors. Will be overwritten by the bench bot anyways.

Open Tasks

Fix remaining errors in snowbridge test code @claravanstaden
Enable Encointer and fix errors
Bump to stable 2503-2
Find all missing storage migrations
Update Changelog
Waiting for new polkadot-sdk release with fixed pallet_session migration
Waiting for new frame-omni-bencher binary with [FRAME] Omni bencher fixes paritytech/polkadot-sdk#8265

Follow Ups:

Rebench
Add pallet_revive to Kusama AssetHub
Bump transaction_version

Re-Enable as last step

paritytech/polkadot-sdk#2072

paritytech/polkadot-sdk#6338 paritytech/polkadot-sdk#6623 paritytech/polkadot-sdk#6621 paritytech/polkadot-sdk#6715 paritytech/polkadot-sdk#6446 paritytech/polkadot-sdk#7441 paritytech/polkadot-sdk#5723

paritytech/polkadot-sdk#7581

paritytech/polkadot-sdk#7685

paritytech/polkadot-sdk#5501

TODO: - Resolve the `Imbalance` type mismatch on `pallet_staking`

…ves parachain runtime TODO: Check whether we need some `AuthorizedAliasingConsideration`.

…rachains' runtimes TODO: Check whether we need some `AuthorizedAliasingConsideration`.

…ub parachains' runtimes TODO: - important: `core` rewrite over `sp_io`. Can't compile `bridge-hub-polkadot-runtime`. Can't figure out which dependency has the `std` open. - Check whether we need some `AuthorizedAliasingConsideration`.

… parachains' runtimes TODO: - important: `core` rewrite over `sp_io`. Can't compile both parachain runtimes. Can't figure out which dependency has the `std` open. - Check whether we need some `AuthorizedAliasingConsideration`.

[At/2503] Pass compilation for several runtimes

athei · 2025-06-04T11:18:55Z

Added the follow up item. Merged master hoping that it fixes the review bot.

joepetrowski · 2025-06-04T11:32:03Z

I would add here maybe also to check/bump transaction_version (at least for next release we should do it).

Don't we have a tool that checks this?

athei · 2025-06-04T11:36:56Z

CI still failing with "cannot connect to docker". I guess just spurious error? @mutantcornholio

mutantcornholio · 2025-06-04T11:59:00Z

Well, it sure doesn't always happen.

@alvicsam do you know if this situation frequent on github public runners?

bkontur · 2025-06-04T12:20:13Z

Well, it sure doesn't always happen.

@alvicsam do you know if this situation frequent on github public runners?

@mutantcornholio @alvicsam We have intermittent/sporadic issues with Docker flakiness from time to time - either with GitHub Actions (like this error) or the zombienet-smoke test. Let's continue the discussion here please: #752

bkontur · 2025-06-04T12:24:24Z

I would add here maybe also to check/bump transaction_version (at least for next release we should do it).

Don't we have a tool that checks this?

I think @EgorPopelyaev might have and I remember he did it once for fellows here.
But there is still Basti's issue to process this with CI: #69
And maybe with this new PAPI feature it could be easier: #747

bkontur · 2025-06-04T12:26:09Z

CI still failing with "cannot connect to docker". I guess just spurious error? @mutantcornholio

@athei The only workaround I know is to push an empty commit and wait(pray): #467

athei · 2025-06-04T12:43:08Z

Kinda annoying because it will run all the jobs. I guess a new approval will also trigger the job? Let's wait for that.

ggwpez · 2025-06-04T13:52:20Z

CHANGELOG.md

+
+### Changed
+
+- Update to SDK version `stable2503-5` ([polkadot-fellows/runtimes/pull/711](https://github.com/polkadot-fellows/runtimes/pull/711))


I think this is no sufficient for downstream.

Who is downstream? This is a binary.

Yeah, agree, I had an open todo to add a pr here with more details.

Who is downstream? This is a binary.

user of the runtime, end users or dApps calling runtime APIs

we need to surface here all the changes marked as audience “runtime user” from the updated SDK (get them from release notes of 2503, 2503-1, .., 2503-5)

There are a LOT of changes flagged for runtime dev. Should they all be copy pasted?

Only runtime user, but I think usually some of these are mislabelled

OK this is probably a better filter to select only impactful changes: this includes PRs which cause major bumps in non-testnet crates:

Major and non-testnet

Make pallet-recovery supports BlockNumberProvider SDK #6446

Implementation of ah-client and rc-client staking pallets SDK #7582

[staking] Currency Migration and Overstake fix SDK #7763

Adds multi-block election types and refactors current single logic to support it SDK #6034

Only allow apply slash to be executed if the slash amount is atleast ED SDK #6540

dmp: Check that the para exist before delivering a message SDK #6604

Remove ProspectiveParachainsMode from backing subsystem SDK #6215

[AHM] Poke deposits: Multisig pallet SDK #7700

fatxpool: handling limits and priorities improvements SDK #6405

pallet-revive: Adjust error handling of sub calls SDK #6741

Add chain-spec-builder as a subcommand to the polkadot-omni-node SDK #7619

Remove yamux_window_size from network config SDK #7014

apply_authorized_upgrade: Remote authorization if the version check fails SDK #7812

Add and test events to conviction voting pallet SDK #6544

[core-fellowship] Add permissionless import_member SDK #7030

Snowbridge - Ethereum Electra Upgrade Support SDK #7075

runtimes: presets are provided as config patches SDK #6349

deprecate AsyncBackingParams SDK #7254

Make the default 85% usage of the PoV SDK #8040

umbrella: Remove pallet-revive-fixtures SDK #6743

Bounded Slashing: Paginated Offence Processing & Slash Application SDK #7424

Dynamic uncompressed code size limit SDK #7760

Move validator disabling logic to pallet-session SDK #7581

Optimize origin checks SDK #8000

Update Conviction Voting Pallet to Support Block Number Provider SDK #6621

pallet_revive: Switch to 64bit RISC-V SDK #6565

Use Relay Blocknumber in Pallet Broker SDK #5656

Upgrade libp2p to 0.54.1 SDK #6248

Stabilize RPC archive methods to V1 SDK #8104

sync: Send already connected peers to new subscribers SDK #7011

Remove network starter that is no longer needed SDK #6400

revive: Include immutable storage deposit into the contracts storage_base_deposit SDK #7230

Snowbridge V2 SDK #7402
Add voting hooks to Conviction_Voting SDK #7703

Introduce pallet-asset-rewards SDK #3926

Removes constraint in BlockNumberProvider from treasury SDK #6522

Update Society Pallet to Support Block Number Provider SDK #6623

Add Runtime Api version to metadata SDK #7607

pallet-xcm: add support to authorize aliases SDK #6336

Add missing events to nomination pool extrinsics SDK #7377

Implement pallet-assets-holder and consider ED part of frozen amount in pallet-assets SDK #4530

[AHM] Poke deposits: Indices pallet SDK #7587

pallet_revive: Change address derivation to use hashing SDK #7662

Remove usage of AccountKeyring SDK #5899

slot-based-collator: Implement dedicated block import SDK #6481

Fix XCM decoding inconsistencies SDK #7856

[pallet-xcm] waive transport fees based on XcmConfig SDK #5363

slot-based-collator: Move spawning of the futures SDK #6561

Add EventEmitter to XCM Executor SDK #7234

Update Scheduler to have a configurable block number provider SDK #7441

pallet-revive: Fix docs.rs SDK #6896

Add export PoV on slot base collator SDK #7585

[pallet-revive] Update delegate_call to accept address and weight SDK #6111

Remove unused dependencies from pallet_revive SDK #6917

revive: Rework the instruction benchmark SDK #7721

pallet-revive: Statically verify imports on code deployment SDK #6759

Implement pallet view functions SDK #4722

[pallet-revive] implement the gas limit API SDK #6926

Remove pallet::getter from bridges/modules SDK #7120

[pallet-revive] implement the block author API SDK #7198

basic-authorship: debug level is now less spammy SDK #6768

Return iterator in pallet_referenda::TracksInfo::tracks SDK #2072

Remove feature test-helpers from sc-service SDK #5855

Deprecate ParaBackingState API SDK #6867

frame-benchmarking: Use correct components for pallet instances SDK #6435

TransactionPool API uses async_trait SDK #6528

AHM Multi-block staking election pallet SDK #7282

[pallet-broker] add extrinsic to remove a lease SDK #7026

Currency to Fungible migration for pallet-staking SDK #5501

Migrate executor into PolkaVM 0.18.0 SDK #6533

Make pallet-bridge-rewards generic over RewardKind SDK #7492

[pallet-revive] change some getter APIs to return value in register SDK #6920

[pallet-revive] Remove debug buffer SDK #7163

Rename archive call method result to value SDK #7885

Remove node-side feature flag checks for Elastic Scaling MVP SDK #7286

Revert pallet-staking changes which should be released as a separate pallet SDK #7939

Utility call fallback SDK #6321

remove handling of validation protocol versions 1 and 2 SDK #7449

[XCM] allow signed account to be aliased between system chains SDK #7983

derive DecodeWithMemTracking for Block SDK #7655

runtime-api: remove redundant version checks SDK #7610

slot-based-collator: Allow multiple blocks per slot SDK #7569

Remove pallet::getter from pallet-nft-fractionalization SDK #7124

Add omni-node checks for runtime parachain compatibility SDK #6450

[net/libp2p] Use raw Identify observed addresses to discover external addresses SDK #7338

Update Referenda to Support Block Number Provider SDK #6338

FRAME: Meta Transaction SDK #6428

[pallet-revive] allow delegate calls to non-contract accounts SDK #7729

derive DecodeWithMemTracking for RuntimeCall SDK #7634

Allow configurable number of genesis accounts with specified balances for benchmarking. SDK #6267

[pallet-revive] implement the call data copy API SDK #6880

[pallet-revive] Fix caller_is_root return value SDK #7086

Pallet view functions: improve metadata, API docs and testing SDK #7412

pallet-revive: Remove unused dependencies SDK #6796

New staking::manual_slash extrinsic SDK #7805

On-demand credits SDK #5990

[pallet-revive] Remove revive events SDK #7164

Adds BlockNumberProvider in multisig, proxy and nft pallets SDK #5723

Expose DHT content providers API from sc-network SDK #6711

[pallet-broker] add extrinsic to reserve a system core without having to wait two sale boundaries SDK #4273

Accurate weight reclaim with frame_system::WeightReclaim and cumulus StorageWeightReclaim transaction extensions SDK #6140

Remove ReportCollator message SDK #6628

[pallet-revive] pack exceeding syscall arguments into registers SDK #7319

Refactor pallet-revive-uapi pallet SDK #6866

Assume elastic scaling MVP feature is always enabled in the runtime SDK #7986

[mq pallet] Custom next queue selectors SDK #6059

rpc v2 archive: more verbose error types in API SDK #8109

Introduce ark-ec-vrfs SDK #7669

pallet-revive: Fix the contract size related benchmarks SDK #7568

Update Nomination Pool Pallet to Support Block Number Provider SDK #6715

[pallet-broker] add extrinsic to remove an assignment SDK #7080

[pallet-revive] do not trap the caller on instantiations with duplicate contracts SDK #7414

Forbid v1 descriptors with UMP signals SDK #7127

add poke_deposit extrinsic to pallet-proxy SDK #7801

pallet-revive: disable host functions unused in solidity PolkaVM compiler SDK #6844

Authorize upgrade tests for testnet runtimes + execute_as_governance refactor SDK #7656

[FRAME] Omni bencher fixes SDK #8265

[pallet-revive] tracing prepare support for future tracing APIS SDK #8495

fix epmb solution duplicate issue + add remote mining apparatus to epm SDK #8585

Fix a potential cause of slow parachain blocks SDK #8447

but we don't care about major bumps if the audience does not contain Runtime User - that's why we have audiences, let's filter based on the right one.

later edit: the list above from Oliver looks good 👍

I used that filter (the first list I posted) and it misses a huge amount that users would be interested in but which the sdk prdoc does not include a runtime user section - that's what I meant that we're building on a weak base

edit: also happy with Oliver's list including runtime user and runtime dev. It would be nice to further refine this in future to skip the PR descriptions involving only testnet code/crates not used in this repo

the sdk prdoc does not include a runtime user section - that's what I meant that we're building on a weak base

Yea it is a data-ingestion problem. Garbage-in-garbage out... The dev who merges it is basically the one responsible for good PrDoc.

I have a proposal for tracking work past implementation to integration which should help with this Changelog situation as well.

We can discuss more live in tomorrow's Runtime Weekly Hangout, so join if you're interested in the topic.

TLDR: if we have a process and track features/fixes/etc all the way to integration to runtimes, we can create a "runtime-user-audience-tailored changelog entry" required step of the integration. E.g. I added a new pallet to SDK, when I integrate to runtimes I need to also add high-quality changelog entry explaining the new thing added to the runtime.

ggwpez

LGTM, only critique point is the CHANGELOG.

alvicsam · 2025-06-04T14:52:40Z

Well, it sure doesn't always happen.

@alvicsam do you know if this situation frequent on github public runners?

The were problems on the hub.docker.com: https://www.dockerstatus.com/

UPD: sorry, misread the error (too many errors from docker today 😅). I haven't seen this error previously on the ubuntu-latest runners, only on the fellowship (e.g. fellowship-001)

seadanda

LGTM with some additional Changelog context from 2503, maybe that list of changes targeted at runtime user, but also some links to the release pages? IDK, we're building on a bit of a weak foundation and including everything would be a barrage of information that would probably bury important stuff

ggwpez · 2025-06-04T15:38:39Z

LGTM with some additional Changelog context from 2503, maybe that list of changes targeted at runtime user, but also some links to the release pages? IDK, we're building on a bit of a weak foundation and including everything would be a barrage of information that would probably bury important stuff

Yea we should filter by bump level. The script I posted above should be easy adaptable to highlight that, will try.

seadanda · 2025-06-04T15:46:22Z

I posted a suggested list in a reply to a thread above. I didn't see the script you posted above but wrote one to select PRs causing major bumps in non-testnet crates. Can definitely be refined: #711 (comment)

CHANGELOG.md

Co-authored-by: Adrian Catangiu <[email protected]>

athei · 2025-06-04T19:07:11Z

/merge

fellowship-merge-bot · 2025-06-04T19:24:43Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

kianenigma · 2025-06-05T14:07:12Z

relay/kusama/src/lib.rs

-	fn filter(who: &AccountId) -> bool {
-		pallet_nomination_pools::AllPoolMembers::<Runtime>::contains(who)
-	}
+	type Filter = ();


cc @Ank4n

I recall that we can remove the filter once the migration to holds (possible as per this PR) is done.

Are you okay with this, or you prefer to keep type Filter = pallet_nomination_pools::AllPoolMembers<Runtime>;, do the migration, and remove the filter afterwards?

resolved off-band, all good.

kianenigma · 2025-06-05T14:07:39Z

relay/kusama/src/lib.rs

 	type AdminOrigin = EitherOf<EnsureRoot<AccountId>, StakingAdmin>;
-	// TODO: this will come back later (stable25XY)
-	// type Filter = pallet_staking::AllStakers<Runtime>;
+	type Filter = ();


related to https://github.com/polkadot-fellows/runtimes/pull/711/files#r2128949626

resolved off-band, all good.

athei and others added 30 commits May 5, 2025 16:57

Bump to stable2503

69273cd

Disable encointer

1677663

Re-Enable as last step

Copy over weight files from PolkadotSDK

67f29bd

Derive DecodeWithMemTracking

ad9a484

Change pallet referenda TracksInfo::tracks to return an iterator

5163229

paritytech/polkadot-sdk#2072

Add BlockNumberProvider

4b3e9db

paritytech/polkadot-sdk#6338 paritytech/polkadot-sdk#6623 paritytech/polkadot-sdk#6621 paritytech/polkadot-sdk#6715 paritytech/polkadot-sdk#6446 paritytech/polkadot-sdk#7441 paritytech/polkadot-sdk#5723

[AHM] Moves disabling logic into pallet-session

38466df

paritytech/polkadot-sdk#7581

[Nomination Pool] Make staking restrictions configurable

d977ff3

paritytech/polkadot-sdk#7685

[Staking] Currency <> Fungible migration

21cd816

paritytech/polkadot-sdk#5501

chore: fix zepter

34e9e4c

chore: Update to stable2503-1

d006154

fix(relay): resolve build issues for relay chain runtimes

a030017

TODO: - Resolve the `Imbalance` type mismatch on `pallet_staking`

fix(system-parachains/collectives): resolve build issues for collecti…

2a37f9a

…ves parachain runtime TODO: Check whether we need some `AuthorizedAliasingConsideration`.

fix(system-parachains/coretime): resolve build issues for coretime pa…

fdd487d

…rachains' runtimes TODO: Check whether we need some `AuthorizedAliasingConsideration`.

chore(bridge-hub-polkadot-runtime): add new deps for snowbridge

12f5d54

Merge pull request #1 from pandres95/at/2503

7c71e6c

[At/2503] Pass compilation for several runtimes

fmt

f6f53ad

Add missing dev account genesis

514205a

Taplo

fcd5d96

Switch away from snowbridge-router-primitives

bfb5931

Add more missing genesis fields

795b686

Xcm config fixes

46038d9

Fix tests

7c72c8f

Remove no longer needed filter for snowbridge

d5c349c

Fix more missing genesis fields

233a9ea

Fix snowbridge tests

6bdedf4

Fix staking config for fungibles transition

ed5b898

Add missing genesis fields

f3c3fc5

ggwpez reviewed Jun 4, 2025

View reviewed changes

ggwpez approved these changes Jun 4, 2025

View reviewed changes

seadanda approved these changes Jun 4, 2025

View reviewed changes

acatangiu reviewed Jun 4, 2025

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

Update CHANGELOG.md

05ef52a

Co-authored-by: Adrian Catangiu <[email protected]>

fellowship-merge-bot bot enabled auto-merge (squash) June 4, 2025 19:24

fellowship-merge-bot bot merged commit 34ecb94 into polkadot-fellows:main Jun 4, 2025
61 of 62 checks passed

athei deleted the at/2503 branch June 5, 2025 12:43

kianenigma reviewed Jun 5, 2025

View reviewed changes

acatangiu added this to Runtime releases Jun 6, 2025

github-project-automation bot moved this to Todo in Runtime releases Jun 6, 2025

acatangiu moved this from Todo to Done in Runtime releases Jun 6, 2025

athei mentioned this pull request Jun 6, 2025

Update fellowship runtimes to polkadot-sdk stable2503 paritytech/contract-issues#59

Closed

seadanda mentioned this pull request Jun 6, 2025

Release v1.6.0 (the Plaza upgrade on Kusama) #554

Closed

5 tasks

raymondkfcheung mentioned this pull request Jun 9, 2025

Enable Coretime Integration Tests & Update Changelog for SetTopic Changes #759

Merged

bkontur mentioned this pull request Jul 2, 2025

[AHM] Missing RootLocation for WaivedLocation for AHP #798

Merged

1 task


		### Changed

		- Update to SDK version `stable2503-5` ([polkadot-fellows/runtimes/pull/711](https://github.com/polkadot-fellows/runtimes/pull/711))

Bump to stable2503 #711

Bump to stable2503 #711

Uh oh!

Conversation

athei commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Open Tasks

Follow Ups:

Uh oh!

athei commented Jun 4, 2025

Uh oh!

joepetrowski commented Jun 4, 2025

Uh oh!

athei commented Jun 4, 2025

Uh oh!

mutantcornholio commented Jun 4, 2025

Uh oh!

bkontur commented Jun 4, 2025

Uh oh!

bkontur commented Jun 4, 2025

Uh oh!

bkontur commented Jun 4, 2025

Uh oh!

athei commented Jun 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seadanda Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

acatangiu Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seadanda Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ggwpez left a comment

Choose a reason for hiding this comment

Uh oh!

alvicsam commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seadanda left a comment

Choose a reason for hiding this comment

Uh oh!

ggwpez commented Jun 4, 2025

Uh oh!

seadanda commented Jun 4, 2025

Uh oh!

Uh oh!

athei commented Jun 4, 2025

Uh oh!

fellowship-merge-bot bot commented Jun 4, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Bump to `stable2503` #711

Bump to `stable2503` #711

athei commented May 5, 2025 •

edited

Loading

seadanda Jun 4, 2025 •

edited

Loading

acatangiu Jun 4, 2025 •

edited

Loading

seadanda Jun 4, 2025 •

edited

Loading

alvicsam commented Jun 4, 2025 •

edited

Loading