deprecate AsyncBackingParams #7254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- backing_implicit_view - candidate-validation - prospective-parachains - provisioner - collator protocol (both sides)
alindima
added
the
T8-polkadot
10 tasks
…nc-backing-params
…nc-backing-params
…nc-backing-params
Contributor
Author
|
/cmd prdoc |
sandreim
approved these changes
Jan 31, 2025
Contributor
sandreim
left a comment
sandreim
left a comment
There was a problem hiding this comment.
LGTM modulo some of the PRDoc version bumps. If we are adding new API in a backward compatible manner, it should be minor bump.
Contributor
Author
good point. the prdoc bot bumped all with major by default. I did another pass through the prdoc and demoted most of them to minor |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
This was referenced Feb 4, 2025
Ank4n
pushed a commit
that referenced
this pull request
Feb 6, 2025
Part of #5079. Removes all usage of the static async backing params, replacing them with dynamically computed equivalent values (based on the claim queue and scheduling lookahead). Adds a new runtime API for querying the scheduling lookahead value. If not present, falls back to 3 (the default value that is backwards compatible with values we have on production networks for allowed_ancestry_len) Also resolves most of #4447, removing code that handles async backing not yet being enabled. While doing this, I removed the support for collation protocol version 1 on collators, as it only worked for leaves not supporting async backing (which are none). I also unhooked the legacy v1 statement-distribution (for the same reason as above). That subsystem is basically dead code now, so I had to remove some of its tests as they would no longer pass (since the subsystem no longer sends messages to the legacy variant). I did not remove the entire legacy subsystem yet, as that would pollute this PR too much. We can remove the entire v1 and v2 validation protocols in a follow up PR. In another PR: remove test files with names `prospective_parachains` (it'd pollute this PR if we do now) TODO: - [x] add deprecation warnings - [x] prdoc --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
7 tasks
This was referenced Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5079.
Removes all usage of the static async backing params, replacing them with dynamically computed equivalent values (based on the claim queue and scheduling lookahead).
Adds a new runtime API for querying the scheduling lookahead value. If not present, falls back to 3 (the default value that is backwards compatible with values we have on production networks for allowed_ancestry_len)
Also resolves most of #4447, removing code that handles async backing not yet being enabled.
While doing this, I removed the support for collation protocol version 1 on collators, as it only worked for leaves not supporting async backing (which are none).
I also unhooked the legacy v1 statement-distribution (for the same reason as above). That subsystem is basically dead code now, so I had to remove some of its tests as they would no longer pass (since the subsystem no longer sends messages to the legacy variant). I did not remove the entire legacy subsystem yet, as that would pollute this PR too much. We can remove the entire v1 and v2 validation protocols in a follow up PR.
In another PR: remove test files with names
prospective_parachains(it'd pollute this PR if we do now)TODO: